Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Fix imports in window.py #79841

Closed
csabella opened this issue Jan 5, 2019 · 4 comments
Closed

IDLE: Fix imports in window.py #79841

csabella opened this issue Jan 5, 2019 · 4 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@csabella
Copy link
Contributor

csabella commented Jan 5, 2019

BPO 35660
Nosy @terryjreedy, @csabella
PRs
  • bpo-35660: Fix imports in idlelib.window #11434
  • [3.7] bpo-35660: Fix imports in idlelib.window (GH-11434) #11449
  • [3.7] bpo-35660: Fix imports in idlelib.window (GH-11434) #11449
  • [3.7] bpo-35660: Fix imports in idlelib.window (GH-11434) #11449
  • [3.7] bpo-35660: Fix imports in idlelib.window (GH-11434) #11449
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-01-06.21:29:58.968>
created_at = <Date 2019-01-05.00:13:36.419>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7']
title = 'IDLE: Fix imports in window.py'
updated_at = <Date 2019-01-06.21:29:58.966>
user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2019-01-06.21:29:58.966>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-01-06.21:29:58.968>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-01-05.00:13:36.419>
creator = 'cheryl.sabella'
dependencies = []
files = []
hgrepos = []
issue_num = 35660
keywords = ['patch', 'patch', 'patch']
message_count = 4.0
messages = ['333028', '333067', '333119', '333120']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'cheryl.sabella']
pr_nums = ['11434', '11449', '11449', '11449', '11449']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35660'
versions = ['Python 3.7', 'Python 3.8']
    @csabella
    Copy link
    Contributor Author

    csabella commented Jan 5, 2019

    Remove use of from tkinter import * from windows.py.

    @csabella csabella added type-feature A feature request or enhancement 3.7 (EOL) end of life 3.8 only security fixes labels Jan 5, 2019
    @terryjreedy
    Copy link
    Member

    'import *' is a PEP-8 violation. Depending in the * import to import sys is a bug.

    @terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Jan 5, 2019
    @terryjreedy terryjreedy changed the title IDLE: Remove import * from window.py IDLE: Fix imports in window.py Jan 6, 2019
    @terryjreedy
    Copy link
    Member

    New changeset 11303dd by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-35660: Fix imports in idlelib.window (bpo-11434)
    11303dd

    @miss-islington
    Copy link
    Contributor

    New changeset be37dbf by Miss Islington (bot) in branch '3.7':
    bpo-35660: Fix imports in idlelib.window (GH-11434)
    be37dbf

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @terryjreedy @csabella @miss-islington