Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaks xml.etree.ElementTree.Element.__setsate__() #79189

Closed
serhiy-storchaka opened this issue Oct 17, 2018 · 4 comments
Closed

Leaks xml.etree.ElementTree.Element.__setsate__() #79189

serhiy-storchaka opened this issue Oct 17, 2018 · 4 comments
Assignees
@serhiy-storchaka
Labels
3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@serhiy-storchaka
Copy link
Member

BPO 35008
Nosy @scoder, @serhiy-storchaka, @miss-islington
PRs
  • bpo-35008: Fix possible leaks in Element.__setstate__(). #9924
  • [3.7] bpo-35008: Fix possible leaks in Element.__setstate__(). (GH-9924) #9942
  • [3.6] bpo-35008: Fix possible leaks in Element.__setstate__(). (GH-9924) #9943
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2018-10-18.09:33:45.160>
created_at = <Date 2018-10-17.08:46:01.928>
labels = ['extension-modules', '3.7', '3.8', 'performance']
title = 'Leaks xml.etree.ElementTree.Element.__setsate__()'
updated_at = <Date 2018-10-18.09:33:45.160>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-10-18.09:33:45.160>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2018-10-18.09:33:45.160>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2018-10-17.08:46:01.928>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 35008
keywords = ['patch']
message_count = 4.0
messages = ['327873', '327937', '327941', '327942']
nosy_count = 4.0
nosy_names = ['scoder', 'eli.bendersky', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['9924', '9942', '9943']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue35008'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @serhiy-storchaka
    Copy link
    Member Author

    When call the __setstate__() method of xml.etree.ElementTree.Element in the C implementation for already initialized element it leaks old children.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes labels Oct 17, 2018
    @serhiy-storchaka serhiy-storchaka self-assigned this Oct 17, 2018
    @serhiy-storchaka serhiy-storchaka added extension-modules C modules in the Modules dir performance Performance or resource usage labels Oct 17, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 6f906b3 by Serhiy Storchaka in branch 'master':
    bpo-35008: Fix possible leaks in Element.__setstate__(). (GH-9924)
    6f906b3

    @miss-islington
    Copy link
    Contributor

    New changeset bcbefe2 by Miss Islington (bot) in branch '3.6':
    bpo-35008: Fix possible leaks in Element.__setstate__(). (GH-9924)
    bcbefe2

    @miss-islington
    Copy link
    Contributor

    New changeset 5b9b935 by Miss Islington (bot) in branch '3.7':
    bpo-35008: Fix possible leaks in Element.__setstate__(). (GH-9924)
    5b9b935

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @serhiy-storchaka serhiy-storchaka

    Labels
    3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington