Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Cookies for Secure WebSockets #79092

Closed
pizzapanther mannequin opened this issue Oct 5, 2018 · 2 comments
Closed

Allow Cookies for Secure WebSockets #79092

pizzapanther mannequin opened this issue Oct 5, 2018 · 2 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@pizzapanther
Copy link
Mannequin

pizzapanther mannequin commented Oct 5, 2018

BPO 34911
Nosy @asvetlov, @pizzapanther
PRs
  • bpo-34911: Added support for secure websocket cookies #9734
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-10-08.18:50:04.203>
created_at = <Date 2018-10-05.23:38:48.383>
labels = ['3.8', 'type-feature', 'library']
title = 'Allow Cookies for Secure WebSockets'
updated_at = <Date 2018-10-08.18:50:04.202>
user = 'https://github.com/pizzapanther'

    bugs.python.org fields:

    activity = <Date 2018-10-08.18:50:04.202>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-08.18:50:04.203>
closer = 'asvetlov'
components = ['Library (Lib)']
creation = <Date 2018-10-05.23:38:48.383>
creator = 'pizzapanther'
dependencies = []
files = []
hgrepos = []
issue_num = 34911
keywords = ['patch']
message_count = 2.0
messages = ['327199', '327367']
nosy_count = 2.0
nosy_names = ['asvetlov', 'pizzapanther']
pr_nums = ['9734']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34911'
versions = ['Python 3.8']
    @pizzapanther
    Copy link
    Mannequin Author

    pizzapanther mannequin commented Oct 5, 2018

    http.cookiejar.DefaultCookiePolicy should support the secure websocket protocol wss. WebSockets start off as HTTP requests and then get upgraded but have a different protocol of wss instead of https. This means secure cookies are not passed through by default.

    @pizzapanther pizzapanther mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 5, 2018
    @asvetlov
    Copy link
    Contributor

    asvetlov commented Oct 8, 2018

    New changeset 4c33997 by Andrew Svetlov (Paul Bailey) in branch 'master':
    bpo-34911: Added support for secure websocket cookies (GH-9734)
    4c33997

    @asvetlov asvetlov added the 3.8 only security fixes label Oct 8, 2018
    @asvetlov asvetlov closed this as completed Oct 8, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @asvetlov