Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyObject_Print() doesn't always return -1 on error #79091

Closed
ZackerySpytz mannequin opened this issue Oct 5, 2018 · 5 comments
Closed

PyObject_Print() doesn't always return -1 on error #79091

ZackerySpytz mannequin opened this issue Oct 5, 2018 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Oct 5, 2018

BPO 34910
Nosy @serhiy-storchaka, @ZackerySpytz, @miss-islington
PRs
  • bpo-34910: Ensure PyObject_Print() always returns -1 on error #9733
  • [3.7] bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733) #9739
  • [3.6] bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733) #9740
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-10-06.07:11:01.475>
created_at = <Date 2018-10-05.23:05:07.077>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = "PyObject_Print() doesn't always return -1 on error"
updated_at = <Date 2018-10-06.07:11:01.473>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2018-10-06.07:11:01.473>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-06.07:11:01.475>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2018-10-05.23:05:07.077>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 34910
keywords = ['patch']
message_count = 5.0
messages = ['327197', '327229', '327231', '327232', '327233']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'ZackerySpytz', 'miss-islington']
pr_nums = ['9733', '9739', '9740']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34910'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Oct 5, 2018

    PyObject_Print() returns 0 if PyUnicode_AsEncodedString() fails.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Oct 5, 2018
    @serhiy-storchaka
    Copy link
    Member

    New changeset ae62f01 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
    bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)
    ae62f01

    @miss-islington
    Copy link
    Contributor

    New changeset 177254c by Miss Islington (bot) in branch '3.6':
    bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)
    177254c

    @miss-islington
    Copy link
    Contributor

    New changeset 49fb49d by Miss Islington (bot) in branch '3.7':
    bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)
    49fb49d

    @serhiy-storchaka
    Copy link
    Member

    Thank you Zackery for catching such kind of errors.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington