Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_ssl.c: Possible null pointer dereference #79005

Closed
ZackerySpytz mannequin opened this issue Sep 27, 2018 · 6 comments
Closed

_ssl.c: Possible null pointer dereference #79005

ZackerySpytz mannequin opened this issue Sep 27, 2018 · 6 comments
Assignees
@tiran
Labels
3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir topic-SSL

Comments

@ZackerySpytz
Copy link
Mannequin

ZackerySpytz mannequin commented Sep 27, 2018

BPO 34824
Nosy @vstinner, @tiran, @serhiy-storchaka, @1st1, @ZackerySpytz, @miss-islington
PRs
  • bpo-34824: Fix a possible NULL pointer dereference in _ssl.c #9606
  • [3.7] bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) #9743
  • [3.6] bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) #9744
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tiran'
closed_at = <Date 2018-10-19.23:16:33.305>
created_at = <Date 2018-09-27.17:07:57.102>
labels = ['extension-modules', 'expert-SSL', '3.7', '3.8']
title = '_ssl.c: Possible null pointer dereference'
updated_at = <Date 2018-10-19.23:16:33.304>
user = 'https://github.com/ZackerySpytz'

    bugs.python.org fields:

    activity = <Date 2018-10-19.23:16:33.304>
actor = 'vstinner'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2018-10-19.23:16:33.305>
closer = 'vstinner'
components = ['Extension Modules', 'SSL']
creation = <Date 2018-09-27.17:07:57.102>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 34824
keywords = ['patch']
message_count = 6.0
messages = ['326573', '326814', '327255', '328076', '328077', '328078']
nosy_count = 6.0
nosy_names = ['vstinner', 'christian.heimes', 'serhiy.storchaka', 'yselivanov', 'ZackerySpytz', 'miss-islington']
pr_nums = ['9606', '9743', '9744']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue34824'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @ZackerySpytz
    Copy link
    Mannequin Author

    ZackerySpytz mannequin commented Sep 27, 2018

    If _PyBytes_Resize() fails in _ssl_MemoryBIO_read_impl(), Py_DECREF() will be called on a null pointer.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes labels Sep 27, 2018
    @ZackerySpytz ZackerySpytz mannequin assigned tiran Sep 27, 2018
    @ZackerySpytz ZackerySpytz mannequin added extension-modules C modules in the Modules dir topic-SSL labels Sep 27, 2018
    @serhiy-storchaka
    Copy link
    Member

    Good catch, but there is more than one error here.

    @miss-islington
    Copy link
    Contributor

    New changeset 365ad2e by Miss Islington (bot) (Zackery Spytz) in branch 'master':
    bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606)
    365ad2e

    @vstinner
    Copy link
    Member

    New changeset 4ec9f64 by Victor Stinner (Miss Islington (bot)) in branch '3.7':
    bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) (GH-9743)
    4ec9f64

    @vstinner
    Copy link
    Member

    New changeset d92816d by Victor Stinner (Miss Islington (bot)) in branch '3.6':
    bpo-34824: Fix a possible NULL pointer dereference in _ssl.c (GH-9606) (GH-9744)
    d92816d

    @vstinner
    Copy link
    Member

    Thanks Zackery Spytz for the report and the fix!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tiran tiran

    Labels
    3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir topic-SSL
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @tiran @serhiy-storchaka @miss-islington