Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSI build fails #78432

Closed
kayhayen mannequin opened this issue Jul 27, 2018 · 5 comments
Closed

MSI build fails #78432

kayhayen mannequin opened this issue Jul 27, 2018 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@kayhayen
Copy link
Mannequin

kayhayen mannequin commented Jul 27, 2018

BPO 34251
Nosy @berkerpeksag, @zware, @miss-islington
PRs
  • bpo-34251: Restore msilib.Win64 to preserve compatibility #8510
  • [3.7] bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510) #8538
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-07-29.06:51:31.842>
created_at = <Date 2018-07-27.19:52:35.819>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'MSI build fails'
updated_at = <Date 2018-07-29.06:51:31.838>
user = 'https://bugs.python.org/kayhayen'

    bugs.python.org fields:

    activity = <Date 2018-07-29.06:51:31.838>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-29.06:51:31.842>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2018-07-27.19:52:35.819>
creator = 'kayhayen'
dependencies = []
files = []
hgrepos = []
issue_num = 34251
keywords = ['patch', '3.7regression']
message_count = 5.0
messages = ['322510', '322513', '322591', '322598', '322612']
nosy_count = 4.0
nosy_names = ['kayhayen', 'berker.peksag', 'zach.ware', 'miss-islington']
pr_nums = ['8510', '8538']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34251'
versions = ['Python 3.7', 'Python 3.8']
    @kayhayen
    Copy link
    Mannequin Author

    kayhayen mannequin commented Jul 27, 2018

    Hello there,

    building an MSI for my project fails. I am calling it like this:

    assert subprocess.call(
    (
        sys.executable,
        "setup.py",
        "bdist_msi",
        "--target-version=" + sys.version[:3]
    )
) == 0

    Giving the target version is probably non-sense and from a time, where one script was building multiple MSIs, I no longer do that.

    and it gives:

    File "C:\Python37_64\lib\site-packages\setuptools\init.py", line 129, in setup
    return distutils.core.setup(**attrs)
    File "C:\Python37_64\lib\distutils\core.py", line 148, in setup
    dist.run_commands()
    File "C:\Python37_64\lib\distutils\dist.py", line 966, in run_commands
    self.run_command(cmd)
    File "C:\Python37_64\lib\distutils\dist.py", line 985, in run_command
    cmd_obj.run()
    File "C:\Python37_64\lib\distutils\command\bdist_msi.py", line 256, in run
    self.add_find_python()
    File "C:\Python37_64\lib\distutils\command\bdist_msi.py", line 346, in add_find_python
    if msilib.Win64:
    AttributeError: module 'msilib' has no attribute 'Win64'

    This happens for 32 and 64 bit CPython 3.7.0 installations. The same code works for all of 2.7, 3.3 through to 3.6, so this is a regression.

    Any idea?

    Thanks,
    Kay

    @kayhayen kayhayen mannequin added type-crash A hard crash of the interpreter, possibly with a core dump stdlib Python modules in the Lib dir 3.7 (EOL) end of life labels Jul 27, 2018
    @berkerpeksag
    Copy link
    Member

    msilib.Win64 has been removed in 49ce74e#diff-c762e09a046c2ff3cd91f0643cc58049L12

    I guess the ``if msilib.Win64:`` clause can be replaced with ``if msilib.AMD64:``.

    @berkerpeksag berkerpeksag added type-bug An unexpected behavior, bug, or error and removed type-crash A hard crash of the interpreter, possibly with a core dump labels Jul 27, 2018
    @zware
    Copy link
    Member

    zware commented Jul 28, 2018

    New changeset 11eb1a9 by Zachary Ware (Berker Peksag) in branch 'master':
    bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510)
    11eb1a9

    @miss-islington
    Copy link
    Contributor

    New changeset 1e98d87 by Miss Islington (bot) in branch '3.7':
    bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510)
    1e98d87

    @berkerpeksag
    Copy link
    Member

    Thanks for the report!

    @berkerpeksag berkerpeksag added stdlib Python modules in the Lib dir 3.8 only security fixes and removed stdlib Python modules in the Lib dir labels Jul 29, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @berkerpeksag @zware @miss-islington