Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streams.py:IncompleteReadError message is unclear when expected is None #78396

Closed
mrbell321 mannequin opened this issue Jul 24, 2018 · 5 comments
Closed

streams.py:IncompleteReadError message is unclear when expected is None #78396

mrbell321 mannequin opened this issue Jul 24, 2018 · 5 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir topic-asyncio type-feature A feature request or enhancement

Comments

@mrbell321
Copy link
Mannequin

mrbell321 mannequin commented Jul 24, 2018

BPO 34215
Nosy @asvetlov, @1st1, @ZackerySpytz, @miss-islington, @mrbell321
PRs
  • bpo-34215: Update streams.py:readuntil IncompleteReadError issue #4354
  • bpo-34215: Clarify IncompleteReadError message when "expected" is None #21925
  • [3.9] bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) #23539
  • [3.8] bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) #23540
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-11-28.15:08:09.859>
created_at = <Date 2018-07-24.20:43:44.425>
labels = ['3.8', '3.9', '3.10', 'type-feature', 'library', 'expert-asyncio']
title = 'streams.py:IncompleteReadError message is unclear when expected is None'
updated_at = <Date 2020-11-28.15:08:09.858>
user = 'https://github.com/mrbell321'

    bugs.python.org fields:

    activity = <Date 2020-11-28.15:08:09.858>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2020-11-28.15:08:09.859>
closer = 'asvetlov'
components = ['Library (Lib)', 'asyncio']
creation = <Date 2018-07-24.20:43:44.425>
creator = 'mrbell321@gmail.com'
dependencies = []
files = []
hgrepos = []
issue_num = 34215
keywords = ['patch']
message_count = 5.0
messages = ['322329', '342747', '382002', '382004', '382008']
nosy_count = 6.0
nosy_names = ['asvetlov', 'yselivanov', 'ZackerySpytz', 'Tyler Bell', 'miss-islington', 'mrbell321@gmail.com']
pr_nums = ['4354', '21925', '23539', '23540']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34215'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @mrbell321
    Copy link
    Mannequin Author

    mrbell321 mannequin commented Jul 24, 2018

    This may have already been cleared as I opened the PR months ago
    But the gist is that the Exception is misleading and the test is incorrect.

    @mrbell321 mrbell321 mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jul 24, 2018
    @TylerBell
    Copy link
    Mannequin

    TylerBell mannequin commented May 17, 2019

    I've updated my PR to reflect a better message for the IncompleteReadError exception. When expected is None, the error reads, "IncompleteReadError: 1 bytes read on a total of None expected bytes" which is confusing. My PR changes this to "IncompleteReadError: 1 bytes read on a total of unknown expected bytes". Otherwise, it is required that whoever views the exception text(possibly through layers of abstraction), to know that None(a "low level" programmers decision) is equal to unknown.

    @TylerBell TylerBell mannequin changed the title streams.py:readuntil IncompleteReadError is message is incorrect streams.py:IncompleteReadError is message is unclear when expected is None May 17, 2019
    @csabella csabella added the 3.9 only security fixes label Dec 15, 2019
    @ZackerySpytz ZackerySpytz mannequin added 3.10 only security fixes topic-asyncio and removed 3.9 only security fixes labels Aug 20, 2020
    @ZackerySpytz ZackerySpytz mannequin changed the title streams.py:IncompleteReadError is message is unclear when expected is None streams.py:IncompleteReadError message is unclear when expected is None Aug 20, 2020
    @asvetlov
    Copy link
    Contributor

    New changeset 8085f74 by Zackery Spytz in branch 'master':
    bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925)
    8085f74

    @asvetlov asvetlov added 3.8 only security fixes 3.9 only security fixes labels Nov 28, 2020
    @asvetlov
    Copy link
    Contributor

    New changeset 4498e98 by Miss Islington (bot) in branch '3.8':
    bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) (bpo-23540)
    4498e98

    @asvetlov
    Copy link
    Contributor

    New changeset df6c8bc by Miss Islington (bot) in branch '3.9':
    bpo-34215: Clarify IncompleteReadError message when "expected" is None (GH-21925) (GH-23539)
    df6c8bc

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @asvetlov @csabella