Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json.loads(encoding=<not None>) does not emit deprecation warning. #77642

Closed
Carreau mannequin opened this issue May 11, 2018 · 5 comments
Closed

json.loads(encoding=<not None>) does not emit deprecation warning. #77642

Carreau mannequin opened this issue May 11, 2018 · 5 comments
Labels
3.8 only security fixes

Comments

@Carreau
Copy link
Mannequin

Carreau mannequin commented May 11, 2018

BPO 33461
Nosy @rhettinger, @etrepum, @pitrou, @ezio-melotti, @methane, @serhiy-storchaka, @Carreau
PRs
  • bpo-33461: Emit DeprecationWarning when json.loads(encoding=...) is used #6762
  • bpo-33461: remove json.loads encoding kwarg #6784
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-04-09.07:17:58.398>
created_at = <Date 2018-05-11.02:31:13.007>
labels = ['3.8']
title = 'json.loads(encoding=<not None>) does not emit deprecation warning.'
updated_at = <Date 2019-04-09.07:17:58.398>
user = 'https://github.com/Carreau'

    bugs.python.org fields:

    activity = <Date 2019-04-09.07:17:58.398>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-09.07:17:58.398>
closer = 'methane'
components = []
creation = <Date 2018-05-11.02:31:13.007>
creator = 'mbussonn'
dependencies = []
files = []
hgrepos = []
issue_num = 33461
keywords = ['patch']
message_count = 5.0
messages = ['316384', '316393', '316479', '339600', '339710']
nosy_count = 7.0
nosy_names = ['rhettinger', 'bob.ippolito', 'pitrou', 'ezio.melotti', 'methane', 'serhiy.storchaka', 'mbussonn']
pr_nums = ['6762', '6784']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue33461'
versions = ['Python 3.8']
    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 11, 2018

    The encoding keyword of json.loads is ignored and deprecated. AFAICT this is since Python 3.1.

    Passing a value for encoding does not emit a deprecation warning.

    @serhiy-storchaka
    Copy link
    Member

    I'm wondering if it can be removed at all. Maybe it was left in bpo-4136 due to oversight.

    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 13, 2018

    I've opened #6784 as an alternative that removes it. I was worried to remove it so close to 3.7.

    @methane
    Copy link
    Member

    methane commented Apr 8, 2019

    Since we didn't raise DeprecationWarning, I think at least one version with DeprecationWarning is preferable.

    @methane methane added the 3.8 only security fixes label Apr 8, 2019
    @methane
    Copy link
    Member

    methane commented Apr 9, 2019

    New changeset a8abe09 by Inada Naoki (Matthias Bussonnier) in branch 'master':
    bpo-33461: emit DeprecationWarning when json.loads(encoding=...) is used (GH-6762)
    a8abe09

    @methane methane closed this as completed Apr 9, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @methane @serhiy-storchaka