Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[imaplib] MOVE is a legal command #77517

Closed
mcepl mannequin opened this issue Apr 22, 2018 · 14 comments
Closed

[imaplib] MOVE is a legal command #77517

mcepl mannequin opened this issue Apr 22, 2018 · 14 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@mcepl
Copy link
Mannequin

mcepl mannequin commented Apr 22, 2018

BPO 33336
Nosy @vstinner, @mcepl, @moreati, @miss-islington
PRs
  • bpo-33336: Legalize MOVE command #6569
  • [2.7] bpo-33336: Legalize MOVE command (GH-6569) #8370
  • [3.6] bpo-33336: Legalize MOVE command (GH-6569) #8373
  • [3.7] bpo-33336: Legalize MOVE command (GH-6569) #8386
  • [3.7] bpo-33336, imaplib: Legalize MOVE command (GH-6569) #8409
  • [3.6] bpo-33336, imaplib: Legalize MOVE command (GH-6569) #8410
  • [2.7] bpo-33336, imaplib: Legalize MOVE command (GH-6569) #8411
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-07-23.14:08:22.061>
created_at = <Date 2018-04-22.22:29:42.060>
labels = ['build', '3.8', '3.7', 'extension-modules', 'type-feature', 'library']
title = '[imaplib] MOVE is a legal command'
updated_at = <Date 2018-07-23.14:08:45.001>
user = 'https://github.com/mcepl'

    bugs.python.org fields:

    activity = <Date 2018-07-23.14:08:45.001>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-23.14:08:22.061>
closer = 'vstinner'
components = ['Extension Modules', 'Library (Lib)', 'Cross-Build']
creation = <Date 2018-04-22.22:29:42.060>
creator = 'mcepl'
dependencies = []
files = []
hgrepos = []
issue_num = 33336
keywords = ['patch']
message_count = 14.0
messages = ['315632', '318657', '318658', '321950', '321953', '322078', '322199', '322200', '322201', '322217', '322220', '322222', '322223', '322224']
nosy_count = 5.0
nosy_names = ['vstinner', 'mcepl', 'Alex.Willmer', 'miss-islington', 'Anthony Singleton']
pr_nums = ['6569', '8370', '8373', '8386', '8409', '8410', '8411']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33336'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']
    @mcepl
    Copy link
    Mannequin Author

    mcepl mannequin commented Apr 22, 2018

    When running

        box = IMAP4_SSL(host)
    box.login(user, pass)
    msgs = somehowget_uids_of_messsages_to_move()
    box.uid('MOVE', msgs, 'target')

    I get an error "Unknown IMAP4 UID command: MOVE". The problem is that imaplib contains a list Commands of the permitted IMAP commands, and MOVE is not included, even though it is perfectly legal (and quite widely supported) command according to RFC-6851.

    @mcepl mcepl mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir labels Apr 22, 2018
    @terryjreedy terryjreedy added type-feature A feature request or enhancement and removed 3.7 (EOL) end of life labels Apr 27, 2018
    @vstinner
    Copy link
    Member

    vstinner commented Jun 4, 2018

    https://tools.ietf.org/html/rfc6851
    Internet Message Access Protocol (IMAP) - MOVE Extension
    January 2013

    @vstinner
    Copy link
    Member

    vstinner commented Jun 4, 2018

    Should we also add the MOVE command to Python 2.7, 3.6 and 3.7? The change looks safe and trivial.

    @vstinner
    Copy link
    Member

    Should we also add the MOVE command to Python 2.7, 3.6 and 3.7? The change looks safe and trivial.

    IMHO it's ok to backport this change. The stdlib must follow evolutions of the IMAP protocol. It's a self contained and safe change, it's not a new Python method.

    @vstinner
    Copy link
    Member

    See also bpo-33327: Add a method to move messages to IMAPlib.

    @mcepl mcepl mannequin added the 3.7 (EOL) end of life label Jul 21, 2018
    @AnthonySingleton
    Copy link
    Mannequin

    AnthonySingleton mannequin commented Jul 21, 2018

    Fuck you

    @AnthonySingleton AnthonySingleton mannequin added extension-modules C modules in the Modules dir build The build process and cross-build labels Jul 21, 2018
    @vstinner
    Copy link
    Member

    New changeset caa331d by Victor Stinner (Matěj Cepl) in branch 'master':
    bpo-33336, imaplib: Legalize MOVE command (GH-6569)
    caa331d

    @vstinner
    Copy link
    Member

    Matěj Cepl: There is a bot to backport changes to other branches. I closed your backport PRs. I prefer to polish the change for the master branch, and only backport later. For example, I modified the commit message of your PR. The bot also uses "git cherry-pick -x" to mention the sha1 of the backported commit which helps to track the origin of backports.

    @vstinner
    Copy link
    Member

    I don't think that "git cherry-pick -x" can be used before a PR is merged, since the merge changes the SHA1 (using our current workflow).

    @miss-islington
    Copy link
    Contributor

    New changeset 1127849 by Miss Islington (bot) in branch '3.6':
    bpo-33336, imaplib: Legalize MOVE command (GH-6569)
    1127849

    @vstinner
    Copy link
    Member

    New changeset 96bba04 by Victor Stinner (Miss Islington (bot)) in branch '3.7':
    bpo-33336, imaplib: Legalize MOVE command (GH-6569) (GH-8409)
    96bba04

    @miss-islington
    Copy link
    Contributor

    New changeset 7868426 by Miss Islington (bot) in branch '2.7':
    bpo-33336, imaplib: Legalize MOVE command (GH-6569)
    7868426

    @vstinner
    Copy link
    Member

    Matěj Cepl: Thanks for your change. I applied it to 2.7, 3.6, 3.7 and master branches.

    @vstinner
    Copy link
    Member

    Anthony Singleton: "Fuck you"

    What does justify this verbal violence?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @terryjreedy @miss-islington