Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linecache.py add lazycache to __all__ and use dict.clear to clear the cache #76354

Closed
ganziqim mannequin opened this issue Nov 30, 2017 · 5 comments
Closed

linecache.py add lazycache to __all__ and use dict.clear to clear the cache #76354

ganziqim mannequin opened this issue Nov 30, 2017 · 5 comments
Assignees
@lisroach
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@ganziqim
Copy link
Mannequin

ganziqim mannequin commented Nov 30, 2017

BPO 32173
Nosy @akuchling, @rhettinger, @serhiy-storchaka, @lisroach, @ganziqim
PRs
  • bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #4603
  • bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #4641
  • bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache  #10130
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/lisroach'
closed_at = <Date 2020-03-21.00:28:33.453>
created_at = <Date 2017-11-30.02:57:02.561>
labels = ['type-bug', 'library']
title = 'linecache.py add lazycache to __all__ and use dict.clear to clear the cache'
updated_at = <Date 2020-03-21.00:28:33.449>
user = 'https://github.com/GanZiQim'

    bugs.python.org fields:

    activity = <Date 2020-03-21.00:28:33.449>
actor = 'akuchling'
assignee = 'lisroach'
closed = True
closed_date = <Date 2020-03-21.00:28:33.453>
closer = 'akuchling'
components = ['Library (Lib)']
creation = <Date 2017-11-30.02:57:02.561>
creator = 'ganziqim'
dependencies = []
files = []
hgrepos = []
issue_num = 32173
keywords = ['patch']
message_count = 5.0
messages = ['307406', '307409', '307419', '328571', '364724']
nosy_count = 5.0
nosy_names = ['akuchling', 'rhettinger', 'serhiy.storchaka', 'lisroach', 'ganziqim']
pr_nums = ['4603', '4641', '10130']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32173'
versions = ['Python 3.6']
    @ganziqim ganziqim mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Nov 30, 2017
    @rhettinger
    Copy link
    Contributor

    These seems to be reasonable suggestions.

    Lisa, would you care to review the patch?

    @serhiy-storchaka
    Copy link
    Member

    Could you please explain your suggestion ganziqim?

    The patch looks like a collection of unrelated changes mostly changing the formatting of the code. Usually we don't do such changes. If there is a semantical change, it is hidden in a source churn.

    @lisroach
    Copy link
    Contributor

    lisroach commented Dec 2, 2017

    I think these changes look good, ganziqim has real code improvements (in the form of adding lazycache to __all__ and using clear() in clearchache), as well as improving the code formatting for readability.

    @serhiy-storchaka
    Copy link
    Member

    Since all proposed PRs just change formatting, I suggest to close this issue.

    @akuchling
    Copy link
    Member

    Patch has been applied.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @lisroach lisroach

    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @akuchling @rhettinger @serhiy-storchaka @lisroach