Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoggerAdapter objects cannot be nested #75638

Closed
ambv opened this issue Sep 13, 2017 · 8 comments
Closed

LoggerAdapter objects cannot be nested #75638

ambv opened this issue Sep 13, 2017 · 8 comments
Assignees
@ambv
Labels
3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error

Comments

@ambv
Copy link
Contributor

ambv commented Sep 13, 2017

BPO 31457
Nosy @vsajip, @ambv, @Mariatta
PRs
  • bpo-31457: Allow for nested LoggerAdapter objects #3551
  • [3.6] bpo-31457: Allow for nested LoggerAdapter objects (GH-3551) #3576
  • bpo-31457: Make the LoggerAdapter.manager property settable #4042
  • [3.6] bpo-31457: Make the LoggerAdapter.manager property settable (GH-4042) #4043
  • bpo-31457: Don't omit inner process() calls with nested LogAdapters #4044
  • [3.6] bpo-31457: Don't omit inner process() calls with nested LogAdapters #4050
  • [3.6] bpo-31457: Don't omit inner process() calls with nested LogAdapters (GH-4044) #6568
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ambv'
closed_at = <Date 2017-09-14.17:51:52.625>
created_at = <Date 2017-09-13.20:15:11.999>
labels = ['type-bug', '3.7']
title = 'LoggerAdapter objects cannot be nested'
updated_at = <Date 2018-04-22.22:00:33.135>
user = 'https://github.com/ambv'

    bugs.python.org fields:

    activity = <Date 2018-04-22.22:00:33.135>
actor = 'lukasz.langa'
assignee = 'lukasz.langa'
closed = True
closed_date = <Date 2017-09-14.17:51:52.625>
closer = 'lukasz.langa'
components = []
creation = <Date 2017-09-13.20:15:11.999>
creator = 'lukasz.langa'
dependencies = []
files = []
hgrepos = []
issue_num = 31457
keywords = ['patch']
message_count = 8.0
messages = ['302111', '302175', '302182', '304598', '304599', '304622', '304630', '315631']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'lukasz.langa', 'Mariatta']
pr_nums = ['3551', '3576', '4042', '4043', '4044', '4050', '6568']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31457'
versions = ['Python 3.6', 'Python 3.7']
    @ambv
    Copy link
    Contributor Author

    ambv commented Sep 13, 2017

    LoggerAdapter objects cannot be nested in Python 3 due to their log() and isEnabledFor() methods addressing attributes that are not present on the proxy.

    Adding the missing attributes fixes the issue.

    @ambv ambv self-assigned this Sep 13, 2017
    @ambv ambv added the type-bug An unexpected behavior, bug, or error label Sep 13, 2017
    @ambv ambv changed the title LoggerAdapter LoggerAdapter objects cannot be nested Sep 13, 2017
    @ambv ambv added the 3.7 (EOL) end of life label Sep 13, 2017
    @ambv
    Copy link
    Contributor Author

    ambv commented Sep 14, 2017

    New changeset 1bbd482 by Łukasz Langa in branch 'master':
    bpo-31457: Allow for nested LoggerAdapter objects (bpo-3551)
    1bbd482

    @ambv
    Copy link
    Contributor Author

    ambv commented Sep 14, 2017

    New changeset 20fa05d by Łukasz Langa (Miss Islington (bot)) in branch '3.6':
    [3.6] bpo-31457: Allow for nested LoggerAdapter objects (GH-3551) (bpo-3576)
    20fa05d

    @ambv ambv closed this as completed Sep 14, 2017
    @ambv
    Copy link
    Contributor Author

    ambv commented Oct 19, 2017

    New changeset 0b6a118 by Łukasz Langa in branch 'master':
    bpo-31457: Make the LoggerAdapter.manager property settable (bpo-4042)
    0b6a118

    @ambv
    Copy link
    Contributor Author

    ambv commented Oct 19, 2017

    New changeset 537ed75 by Łukasz Langa (Miss Islington (bot)) in branch '3.6':
    [3.6] bpo-31457: Make the LoggerAdapter.manager property settable (GH-4042) (bpo-4043)
    537ed75

    @ambv
    Copy link
    Contributor Author

    ambv commented Oct 19, 2017

    New changeset ce9e625 by Łukasz Langa in branch 'master':
    bpo-31457: Don't omit inner process() calls with nested LogAdapters (bpo-4044)
    ce9e625

    @Mariatta
    Copy link
    Member

    New changeset 4d9a8f2 by Mariatta (Miss Islington (bot)) in branch '3.6':
    bpo-31457: Don't omit inner process() calls with nested LogAdapters (GH-4044) (GH-4050)
    4d9a8f2

    @ambv
    Copy link
    Contributor Author

    ambv commented Apr 22, 2018

    New changeset 26c289d by Łukasz Langa (Miss Islington (bot)) in branch '3.6':
    bpo-31457: Don't omit inner process() calls with nested LogAdapters (GH-4044) (bpo-6568)
    26c289d

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland mentioned this issue Aug 21, 2023
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ambv ambv

    Labels
    3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ambv @Mariatta