Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test.test_importlib.test_abc to test find_spec() #74388

Closed
brettcannon opened this issue Apr 28, 2017 · 4 comments
Closed

Update test.test_importlib.test_abc to test find_spec() #74388

brettcannon opened this issue Apr 28, 2017 · 4 comments
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir

Comments

@brettcannon
Copy link
Member

BPO 30202
Nosy @brettcannon, @ncoghlan, @ericsnowcurrently, @sayanchowdhury, @nanjekyejoannah
PRs
  • bpo-30202 : Update test.test_importlib.test_abc to test find_spec() #12847
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-21.23:01:07.992>
created_at = <Date 2017-04-28.21:56:12.837>
labels = ['3.7', 'tests']
title = 'Update test.test_importlib.test_abc to test find_spec()'
updated_at = <Date 2019-06-21.23:01:07.992>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2019-06-21.23:01:07.992>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-21.23:01:07.992>
closer = 'brett.cannon'
components = ['Tests']
creation = <Date 2017-04-28.21:56:12.837>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 30202
keywords = ['patch']
message_count = 4.0
messages = ['292552', '294208', '340302', '346240']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'ncoghlan', 'eric.snow', 'sayanchowdhury', 'nanjekyejoannah']
pr_nums = ['12847']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue30202'
versions = ['Python 3.7']
    @brettcannon
    Copy link
    Member Author

    It looks like test_abc isn't really testing find_spec() very much compared to find_module(). There might also be some tests still using find_module() that should be updated to use find_spec() instead.

    @brettcannon brettcannon added 3.7 (EOL) end of life tests Tests in the Lib/test dir labels Apr 28, 2017
    @sayanchowdhury
    Copy link
    Mannequin

    sayanchowdhury mannequin commented May 23, 2017

    I am picking up this issue.

    @nanjekyejoannah
    Copy link
    Member

    Since it was almost 2 years since the last conversation, i opened a PR for this.

    @brett.cannon I may have not looked at all possible areas to use find_spec(), so please let me know in the reviews for this PR.

    @brettcannon
    Copy link
    Member Author

    New changeset a0d73a1 by Brett Cannon (Joannah Nanjekye) in branch 'master':
    bpo-30202 : Update test.test_importlib.test_abc to test find_spec() (GH-12847)
    a0d73a1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @nanjekyejoannah