Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curses attribute constants list is incomplete #74362

Closed
zhangyangyu opened this issue Apr 26, 2017 · 9 comments
Closed

curses attribute constants list is incomplete #74362

zhangyangyu opened this issue Apr 26, 2017 · 9 comments
Labels
3.7 (EOL) end of life docs Documentation in the Doc dir

Comments

@zhangyangyu
Copy link
Member

BPO 30176
Nosy @Yhg1s, @vstinner, @berkerpeksag, @serhiy-storchaka, @zhangyangyu, @Mariatta
PRs
  • bpo-30176: add missing curses cell attributes constants #1302
  • [3.6] bpo-30176: Add missing curses cell attributes constants (GH-1302). #2241
  • [3.5] bpo-30176: Add missing curses cell attributes constants #2277
  • [2.7] bpo-30176: Add missing curses cell attributes constants #2278
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-06-19.14:13:28.288>
created_at = <Date 2017-04-26.16:10:21.307>
labels = ['3.7', 'docs']
title = 'curses attribute constants list is incomplete'
updated_at = <Date 2017-06-19.14:13:28.287>
user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2017-06-19.14:13:28.287>
actor = 'xiang.zhang'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-06-19.14:13:28.288>
closer = 'xiang.zhang'
components = ['Documentation']
creation = <Date 2017-04-26.16:10:21.307>
creator = 'xiang.zhang'
dependencies = []
files = []
hgrepos = []
issue_num = 30176
keywords = []
message_count = 9.0
messages = ['292375', '292377', '292379', '292388', '296155', '296195', '296341', '296342', '296343']
nosy_count = 7.0
nosy_names = ['twouters', 'vstinner', 'docs@python', 'berker.peksag', 'serhiy.storchaka', 'xiang.zhang', 'Mariatta']
pr_nums = ['1302', '2241', '2277', '2278']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue30176'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']
    @zhangyangyu zhangyangyu added the 3.7 (EOL) end of life label Apr 26, 2017
    @zhangyangyu zhangyangyu added the docs Documentation in the Doc dir label Apr 26, 2017
    @serhiy-storchaka
    Copy link
    Member

    Initially constants was enumerated in alphabetical order (except A_ITALIC). Maybe continue supporting this order? On other hand, it may be worth to group highlighting attributes separately. A_ATTRIBUTES, A_CHARTEXT and A_COLOR are not specific attributes, but bit masks, they also could be grouped separately or moved into a separate table.

    Perhaps it is worth to add notes for A_ITALIC and highlighting attributes. They are not always available.

    @zhangyangyu
    Copy link
    Member Author

    +1 for group. I added "The exact constants available are system dependent" to note some may be absent.

    @serhiy-storchaka
    Copy link
    Member

    I still think that the difference between the groups should be documented in more details. Not all functions that support A_BOLD support also A_ITALIC and A_HORIZONTAL (even if they are defined). Bit masks are used in totally different way than other constants.

    @zhangyangyu
    Copy link
    Member Author

    I can't find any official, portable doc about the details so I don't prefer to have them. I support bit-masks are different. Previously I don't what's the better way to organize them, now I have a try. Please check the update. :-)

    @Mariatta
    Copy link
    Member

    New changeset 116dd5e by Mariatta (Xiang Zhang) in branch 'master':
    bpo-30176: Add missing curses cell attributes constants (GH-1302)
    116dd5e

    @Mariatta
    Copy link
    Member

    New changeset 304a96e by Mariatta in branch '3.6':
    bpo-30176: Add missing curses cell attributes constants (GH-1302). (GH-2241)
    304a96e

    @zhangyangyu
    Copy link
    Member Author

    New changeset 04521c2 by Xiang Zhang in branch '3.5':
    bpo-30176: Add missing curses cell attributes constants (bpo-2277)
    04521c2

    @zhangyangyu
    Copy link
    Member Author

    New changeset b39a748 by Xiang Zhang in branch '2.7':
    bpo-30176: Add missing curses cell attributes constants (bpo-2278)
    b39a748

    @zhangyangyu
    Copy link
    Member Author

    Thanks Mariatta and Serhiy!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life docs Documentation in the Doc dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @serhiy-storchaka @zhangyangyu @Mariatta