Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor regression in PyEval_CallObjectWithKeywords() #73870

Closed
methane opened this issue Mar 1, 2017 · 4 comments
Closed

Minor regression in PyEval_CallObjectWithKeywords() #73870

methane opened this issue Mar 1, 2017 · 4 comments

Comments

@methane
Copy link
Member

methane commented Mar 1, 2017

BPO 29684
Nosy @vstinner, @methane
PRs
  • bpo-29684: Fix regression of PyEval_CallObjectWithKeywords #87
  • [3.6] bpo-29684: Fix minor regression of PyEval_CallObjectWithKeywords. #378
  • [Do Not Merge] Sample of CPython life with blurb. #703
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-03-01.12:37:29.511>
created_at = <Date 2017-03-01.09:20:00.223>
labels = []
title = 'Minor regression in PyEval_CallObjectWithKeywords()'
updated_at = <Date 2017-03-31.16:36:12.571>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:12.571>
actor = 'dstufft'
assignee = 'none'
closed = True
closed_date = <Date 2017-03-01.12:37:29.511>
closer = 'vstinner'
components = []
creation = <Date 2017-03-01.09:20:00.223>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 29684
keywords = ['3.6regression']
message_count = 4.0
messages = ['288748', '288755', '290353', '290354']
nosy_count = 2.0
nosy_names = ['vstinner', 'methane']
pr_nums = ['87', '378', '703', '552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue29684'
versions = []
    @methane
    Copy link
    Member Author

    methane commented Mar 1, 2017

    This issue is spin off bpo-29548.

    PyEval_CallObjectWithKeywords(PyObject *func, PyObject *args, PyObject *kwargs)
should raise TypeError when kwargs is not dict.
But after this commit [1], assert(PyDict_Check(kwargs)) can be called when args==NULL.

    [1] 155ea65

    @vstinner
    Copy link
    Member

    vstinner commented Mar 1, 2017

    Both PR have been merged, I close the issue.

    @vstinner vstinner closed this as completed Mar 1, 2017
    @methane
    Copy link
    Member Author

    methane commented Mar 24, 2017

    New changeset 023532e by INADA Naoki in branch '3.6':
    bpo-29684: Fix minor regression of PyEval_CallObjectWithKeywords. (GH-378)
    023532e

    @methane
    Copy link
    Member Author

    methane commented Mar 24, 2017

    New changeset 3824cd8 by INADA Naoki in branch 'master':
    bpo-29684: Fix regression of PyEval_CallObjectWithKeywords (GH-87)
    3824cd8

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @methane