-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compileall does not support pathlib #72413
Comments
Is there a fix for compileall missing from the patch? All I see are a new test. |
No, os.path.* functions have taken care of the conversion, but the output was in the following format:
I fixed it, added a test for the ddir argument and simplified tests a bit. |
New changeset a6f0cc1820f4 by Berker Peksag in branch '3.6': New changeset fcce24bc9416 by Berker Peksag in branch 'default': |
I found a similar problem in compile_dir() and fixed it in the commit. |
Thanks, Berker Peksag! |
Windows buildbots didn't like a6f0cc1820f4 :) Fix is incoming. ====================================================================== Traceback (most recent call last):
File "D:\buildarea\3.6.ware-win81-release\build\lib\test\test_compileall.py", line 161, in test_compile_dir_pathlike
self.assertIn("Listing '{}'...".format(self.directory), stdout.getvalue())
AssertionError: "Listing 'D:\\temp\\tmpuziqv_kw'..." not found in "Listing 'D:\\\\temp\\\\tmpuziqv_kw'...\nListing 'D:\\\\temp\\\\tmpuziqv_kw\\\\_subdir'...\nCompiling 'D:\\\\temp\\\\tmpuziqv_kw\\\\_subdir\\\\_test3.py'...\nCompiling 'D:\\\\temp\\\\tmpuziqv_kw\\\\_test.py'...\nCompiling 'D:\\\\temp\\\\tmpuziqv_kw\\\\_test2.py'...\n" ====================================================================== Traceback (most recent call last):
File "D:\buildarea\3.6.ware-win81-release\build\lib\test\test_compileall.py", line 111, in test_compile_file_pathlike
"Compiling '{}'...\n".format(self.source_path))
AssertionError: "Compiling 'D:\\\\temp\\\\tmpqvjkm0fm\\\\_test.py'...\n" != "Compiling 'D:\\temp\\tmpqvjkm0fm\\_test.py'...\n"
- Compiling 'D:\\temp\\tmpqvjkm0fm\\_test.py'...
? - - -
+ Compiling 'D:\temp\tmpqvjkm0fm\_test.py'... |
New changeset 13cd90bdcfbe by Berker Peksag in branch '3.6': New changeset ff80d77200ed by Berker Peksag in branch 'default': |
Misc/NEWS
so that it is managed by towncrier #552Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: