Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module_from_spec() should raise an error in 3.6 #72213

Closed
ericsnowcurrently opened this issue Sep 8, 2016 · 3 comments
Closed

module_from_spec() should raise an error in 3.6 #72213

ericsnowcurrently opened this issue Sep 8, 2016 · 3 comments
Assignees
@ericsnowcurrently
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

BPO 28026
Nosy @brettcannon, @ericsnowcurrently
Files
  • module_from_spec.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2016-09-08.18:15:10.030>
created_at = <Date 2016-09-08.18:01:32.660>
labels = ['interpreter-core', 'type-bug']
title = 'module_from_spec() should raise an error in 3.6'
updated_at = <Date 2016-09-08.18:15:10.030>
user = 'https://github.com/ericsnowcurrently'

    bugs.python.org fields:

    activity = <Date 2016-09-08.18:15:10.030>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2016-09-08.18:15:10.030>
closer = 'eric.snow'
components = ['Interpreter Core']
creation = <Date 2016-09-08.18:01:32.660>
creator = 'eric.snow'
dependencies = []
files = ['44472']
hgrepos = []
issue_num = 28026
keywords = ['patch']
message_count = 3.0
messages = ['275086', '275089', '275098']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28026'
versions = ['Python 3.6']
    @ericsnowcurrently
    Copy link
    Member Author

    In Lib/importlib/_bootstrap.py, module_from_spec() specifies that the current deprecation warning should be an error in 3.6. So, here's a patch.

    @ericsnowcurrently ericsnowcurrently self-assigned this Sep 8, 2016
    @ericsnowcurrently ericsnowcurrently added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Sep 8, 2016
    @brettcannon
    Copy link
    Member

    LGTM

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 8, 2016

    New changeset ada5620efd82 by Eric Snow in branch 'default':
    Issue bpo-28026: Raise ImportError when exec_module() exists but create_module() is missing.
    https://hg.python.org/cpython/rev/ada5620efd82

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericsnowcurrently ericsnowcurrently

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @ericsnowcurrently