New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-gdb.py must be updated for the new Python 3.6 compact dict #72210
Comments
The issue bpo-27350 changed the design of Python dictionaries to make them compact. python-gdb.py must be updated for the new structure of Python dict. |
New changeset 0bd618fe0639 by Victor Stinner in branch 'default': |
I've fixed dict support of python-gdb.py. But I found py-bt and py-bt-full are broken. They doesn't show builtin method. |
Could someone review this before 3.6b2? |
@Haypo, would you review this patch? |
ping |
I reviewed dict_gdb.patch. |
dict_gdb2.patch LGTM. Can you please follow Ned's instructions to get this change merged into 3.6 final? python-gdb.py is an important tool and it's completly broken. The patch cannot make python-gdb.py worse :-D (More seriously, it fixes python-gdb.py.) |
https://mail.python.org/pipermail/python-committers/2016-November/004065.html
So now I think I can commit this for now. |
New changeset 4f6fb9e47f6b by INADA Naoki in branch '3.6': New changeset c51045920410 by INADA Naoki in branch 'default': |
test_gdb failed on a lot of buildbots. Examples:
Extract of the Gentoo non-debug: (...) Traceback (most recent call last):
File "/buildbot/buildarea/3.6.ware-gentoo-x86.nondebug/build/Lib/test/test_gdb.py", line 490, in test_NULL_ob_type
'set v->ob_type=0')
File "/buildbot/buildarea/3.6.ware-gentoo-x86.nondebug/build/Lib/test/test_gdb.py", line 461, in assertSane
cmds_after_breakpoint=cmds_after_breakpoint)
File "/buildbot/buildarea/3.6.ware-gentoo-x86.nondebug/build/Lib/test/test_gdb.py", line 240, in get_gdb_repr
import_site=import_site)
File "/buildbot/buildarea/3.6.ware-gentoo-x86.nondebug/build/Lib/test/test_gdb.py", line 218, in get_stack_trace
self.assertEqual(unexpected_errlines, [])
AssertionError: Lists differ: ["Python Exception <class 'gdb.error'> Can[663 chars].: "] != [] First list contains 10 additional elements. Diff is 745 characters long. Set self.maxDiff to None to see it. |
New changeset 9b974f988c95 by Victor Stinner in branch '3.6': |
Thanks a lot! I hope I can run test on multiple environment before merge, |
Ah nice, it seems like test_gdb pass again. |
Thanks Naoki for the fix ;-) gdb scripts are a little bit weird sometimes, and the API has subtle changes in each minor GDB release :-/ |
Misc/NEWS
so that it is managed by towncrier #552Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: