Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subprocess.__all__ incomplete on Windows #70969

Closed
vadmium opened this issue Apr 16, 2016 · 2 comments
Closed

subprocess.__all__ incomplete on Windows #70969

vadmium opened this issue Apr 16, 2016 · 2 comments
Labels
OS-windows

Comments

@vadmium
Copy link
Member

vadmium commented Apr 16, 2016

BPO 26782
Nosy @pfmoore, @tjguk, @vadmium, @zware, @zooba
Files
  • subprocess-all.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2016-04-17.03:54:19.733>
created_at = <Date 2016-04-16.14:23:28.750>
labels = ['OS-windows']
title = 'subprocess.__all__ incomplete on Windows'
updated_at = <Date 2016-04-17.03:54:19.732>
user = 'https://github.com/vadmium'

    bugs.python.org fields:

    activity = <Date 2016-04-17.03:54:19.732>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-04-17.03:54:19.733>
closer = 'martin.panter'
components = ['Windows']
creation = <Date 2016-04-16.14:23:28.750>
creator = 'martin.panter'
dependencies = []
files = ['42491']
hgrepos = []
issue_num = 26782
keywords = ['patch']
message_count = 2.0
messages = ['263557', '263592']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'martin.panter', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue26782'
versions = ['Python 3.6']
    @vadmium
    Copy link
    Member Author

    vadmium commented Apr 16, 2016

    After enabling test__all__() in test_subprocess on Windows (see bpo-10838), I find that STARTUPINFO is missing from __all__, and there is a class Handle that is ambiguous. Handle doesn’t seem to be documented, so I propose to add it to the intentionally-excluded list.

    In Python 3.5 I will fix the test to exclude STARTUPINFO from __all__.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 16, 2016

    New changeset 386712b16c74 by Martin Panter in branch '3.5':
    Issue bpo-26782: Acknowledge the incomplete status of __all__ in 3.5
    https://hg.python.org/cpython/rev/386712b16c74

    New changeset 728370e7a29d by Martin Panter in branch 'default':
    Issue bpo-26782: Merge test_subprocess from 3.5
    https://hg.python.org/cpython/rev/728370e7a29d

    New changeset 3e93ac5a7afa by Martin Panter in branch 'default':
    Issue bpo-26782: Add STARTUPINFO to subprocess.__all__ on Windows
    https://hg.python.org/cpython/rev/3e93ac5a7afa

    @vadmium vadmium closed this as completed Apr 17, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @vadmium