Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give AST's excepthandler proper attributes #46763

Closed
birkenfeld opened this issue Mar 29, 2008 · 3 comments
Closed

Give AST's excepthandler proper attributes #46763

birkenfeld opened this issue Mar 29, 2008 · 3 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@birkenfeld
Copy link
Member

BPO 2511
Nosy @loewis, @birkenfeld
Files
  • ast-except.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/birkenfeld'
    closed_at = <Date 2008-03-30.06:40:25.967>
    created_at = <Date 2008-03-29.18:30:07.804>
    labels = ['interpreter-core']
    title = "Give AST's excepthandler proper attributes"
    updated_at = <Date 2008-03-30.06:40:25.949>
    user = 'https://github.com/birkenfeld'

    bugs.python.org fields:

    activity = <Date 2008-03-30.06:40:25.949>
    actor = 'georg.brandl'
    assignee = 'georg.brandl'
    closed = True
    closed_date = <Date 2008-03-30.06:40:25.967>
    closer = 'georg.brandl'
    components = ['Interpreter Core']
    creation = <Date 2008-03-29.18:30:07.804>
    creator = 'georg.brandl'
    dependencies = []
    files = ['9892']
    hgrepos = []
    issue_num = 2511
    keywords = ['patch']
    message_count = 3.0
    messages = ['64714', '64721', '64742']
    nosy_count = 2.0
    nosy_names = ['loewis', 'georg.brandl']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue2511'
    versions = ['Python 2.6', 'Python 3.0']

    @birkenfeld
    Copy link
    Member Author

    The ASDL file has an XXX comment about excepthandler's lineno and
    col_offset -- they are not attributes but fields which gets confusing
    when this is exported to Python code. I think the only way to solve this
    is to make it a "trivial" Sum with one element. This patch does that.

    @birkenfeld birkenfeld added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Mar 29, 2008
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Mar 29, 2008

    Sounds fine to me.

    @loewis loewis mannequin assigned birkenfeld and unassigned loewis Mar 29, 2008
    @birkenfeld
    Copy link
    Member Author

    Committed in r62047.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant