You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of trying to understand the IDLE codebase, I'm taking a look at IDLE's unit tests.
-Added more specific messages when test_delegator.py's assertions fail.
-Added detail to the comments.
-Added an explicit test of the resetcache() method (which before was only tested as far as it was called when setdelegate() was called).
I've rerun the unit test on the existing source code and it passes.
The patch adds too much. Some of the comments are too obvious. See PEP-8. Many of the messages repeat the information already provided in the custom messages already provided by the assertXyz failure methods. For instance, when assertEqual(a, b) fails, the message already prints out something like "%s != $s" % (repr(a), repr(b)). Perhaps you were not familiar with this. One of the problems of retrofitting tests is that we do not see the default failure messages.
In any case, over-commenting and over-messaging are not harmless as they make code and failure messages harder, not easier to read. I will review and add what I think is useful.
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: