-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comparison of ipaddress classes #67457
Comments
Here is a patch which fixes following errors in comparison of ipaddress classes.
As far as functools.total_ordering now is fixed and more correct and tested than _TotalOrderingMixin, _TotalOrderingMixin is dropped away. |
+1, looks good to me. That test for ordering and comparison interoperability is actually pretty neat - I wonder if we could make it more generally available as a "check my class handles NotImplemented correctly" check (in unittest?), which would potentially be useful in pursuing a fix for issue bpo-11477. The fact the default __ne__ implementation doesn't handle NotImplemented correctly should probably be filed as a separate issue. |
May be this is a part of bpo-21408. |
New changeset 9a7d965ab80f by Serhiy Storchaka in branch '3.4': New changeset 051f2a234d8a by Serhiy Storchaka in branch 'default': |
!=
to the right-hand side argument is not always doneNote: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: