New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_sre.SRE_Scanner object should have a fullmatch() method #65201
Comments
I believe that the SRE_Scanner object should have a .fullmatch() method for consistency with other re pattern-matching behaviour. >>> rex = re.compile('([^\\W\\d_]{1,2}[0-9]{1,2}[^\\d\\W_]?)[ \\t]*([0-9][^\\d\\W_]{2})')
>>> rex.scanner('bn20bs')
<_sre.SRE_Scanner object at 0x102006400>
>>> rex.scanner('bn20bs').search()
<_sre.SRE_Match object; span=(0, 6), match='bn20bs'>
>>> rex.scanner('bn20bs').match()
<_sre.SRE_Match object; span=(0, 6), match='bn20bs'>
>>> rex.scanner('bn20bs').fullmatch() Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: '_sre.SRE_Scanner' object has no attribute 'fullmatch' |
I also encountered bpo-20998, which explains the convoluted [^\\W\\d_] in place of [a-zA-Z] as I was investigating why case-insensitivity and quantifiers would not work together. |
Scanner isn't a public interface, so the real enhancement here would be to make it one, in which case adding fullmatch would make sense. I don't know if making it public is a good idea or not. |
Scanner may not be a public interface but it is widely documented, not least on page 67 of the O'reilly Python Cookbook. Even if Scanner is not made public, then surely it should maintain consistency with the public interfaces? |
Scanner is not documented in CPython's own re documentation: https://docs.python.org/3/library/re.html#regular-expression-objects, so I'd say there's no obligation to maintain consistency with public APIs. Is anyone able to make a call on whether this issue should be closed, or alternatively give some guidance on what work this issue should encompass? |
Added Serhiy to the nosy list, since he's an active maintainer for the re module. |
I concur with David. The SRE_Scanner object is not public. Its search() method is used for implementing finditer(). Its match() method could be useful for implementing a functional equivalent of \G in Perl. But I do not know a use case for its fullmatch() method. If anybody provide a use case for SRE_Scanner.fullmatch() this issue can be reopened. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: