Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review additions to the stable ABI of Python 3.4 #63725

Closed
vstinner opened this issue Nov 8, 2013 · 5 comments
Closed

Review additions to the stable ABI of Python 3.4 #63725

vstinner opened this issue Nov 8, 2013 · 5 comments
Labels
release-blocker

Comments

@vstinner
Copy link
Member

vstinner commented Nov 8, 2013

BPO 19526
Nosy @loewis, @ncoghlan, @vstinner, @larryhastings

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-01-04.10:32:11.067>
created_at = <Date 2013-11-08.11:18:15.515>
labels = ['release-blocker']
title = 'Review additions to the stable ABI of Python 3.4'
updated_at = <Date 2014-01-04.10:32:11.066>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2014-01-04.10:32:11.066>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2014-01-04.10:32:11.067>
closer = 'loewis'
components = []
creation = <Date 2013-11-08.11:18:15.515>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 19526
keywords = []
message_count = 5.0
messages = ['202412', '202413', '202416', '207245', '207246']
nosy_count = 5.0
nosy_names = ['loewis', 'ncoghlan', 'vstinner', 'larry', 'python-dev']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue19526'
versions = ['Python 3.4']
@vstinner
Copy link
Member Author

vstinner commented Nov 8, 2013

Example:

http://hg.python.org/cpython/rev/69071054b42f
PyAPI_FUNC(int) _PyDict_DelItemId(PyObject *mp, struct _Py_Identifier *key);

New functions added in this issue should also be reviewed (should them be part of the stable ABI?):

http://bugs.python.org/issue11619
http://hg.python.org/cpython/rev/df2fdd42b375

@vstinner
Copy link
Member Author

vstinner commented Nov 8, 2013

"Priority: release blocker" means that it should be done at least before Python 3.4 final. It may be delayed after the beta1.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 8, 2013

New changeset bf9c77bac36d by Victor Stinner in branch 'default':
Issue bpo-19512, bpo-19526: Exclude the new _PyDict_DelItemId() function from the
http://hg.python.org/cpython/rev/bf9c77bac36d

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jan 3, 2014

New changeset 15bad3abfac9 by Martin v. Löwis in branch 'default':
Issue bpo-19526: Exclude all new API from the stable ABI.
http://hg.python.org/cpython/rev/15bad3abfac9

@loewis
Copy link
Mannequin

loewis mannequin commented Jan 3, 2014

The procedure to obtain the new API was this:

  • write a C file
#define Py_LIMITED_API
#include <Python.h>

  • compile this with gcc -E | grep -v '#'

  • diff and inspect the two preprocessor outputs. Ideally, they come out empty, but they currently show lots of (legitimate) const additions, and some reformattings

@loewis loewis mannequin closed this as completed Jan 4, 2014
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner