Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wave.Wave_read and wave.Wave_write can be context managers #61816

Closed
PCManticore mannequin opened this issue Apr 2, 2013 · 4 comments
Closed

wave.Wave_read and wave.Wave_write can be context managers #61816

PCManticore mannequin opened this issue Apr 2, 2013 · 4 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@PCManticore
Copy link
Mannequin

PCManticore mannequin commented Apr 2, 2013

BPO 17616
Nosy @bitdancer, @PCManticore
Files
  • wave_context_manager.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2013-07-31.17:50:58.341>
created_at = <Date 2013-04-02.09:16:06.751>
labels = ['type-feature', 'library']
title = 'wave.Wave_read and wave.Wave_write can be context managers'
updated_at = <Date 2013-08-01.00:48:43.915>
user = 'https://github.com/PCManticore'

    bugs.python.org fields:

    activity = <Date 2013-08-01.00:48:43.915>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2013-07-31.17:50:58.341>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2013-04-02.09:16:06.751>
creator = 'Claudiu.Popa'
dependencies = []
files = ['29653']
hgrepos = []
issue_num = 17616
keywords = ['patch']
message_count = 4.0
messages = ['185825', '194004', '194005', '194029']
nosy_count = 3.0
nosy_names = ['r.david.murray', 'Claudiu.Popa', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17616'
versions = ['Python 3.4']
    @PCManticore
    Copy link
    Mannequin Author

    PCManticore mannequin commented Apr 2, 2013

    I think that wave.open should work with the with statement, given the fact that Lib/aifc.py does this. I attached a simple patch for this. Thanks in advance.

    @PCManticore PCManticore mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 2, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 31, 2013

    New changeset 8327780d3841 by R David Murray in branch 'default':
    bpo-17616: wave.open now supports the 'with' statement.
    http://hg.python.org/cpython/rev/8327780d3841

    @bitdancer
    Copy link
    Member

    Thanks, Claudiu.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 1, 2013

    New changeset 4f3b6eff2ede by R David Murray in branch 'default':
    bpo-17616: Improve context manager tests, fix bugs in close method and mode docs.
    http://hg.python.org/cpython/rev/4f3b6eff2ede

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @bitdancer