Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate OSError aliases in the doc #60920

Closed
asvetlov opened this issue Dec 18, 2012 · 14 comments
Closed

Deprecate OSError aliases in the doc #60920

asvetlov opened this issue Dec 18, 2012 · 14 comments

Comments

@asvetlov
Copy link
Contributor

BPO 16716
Nosy @pitrou, @merwok, @bitdancer, @asvetlov
Files
  • exception.patch: Deprecation tag added
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2014-03-31.23:17:05.813>
created_at = <Date 2012-12-18.20:07:22.419>
labels = []
title = 'Deprecate OSError aliases in the doc'
updated_at = <Date 2014-03-31.23:17:05.812>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2014-03-31.23:17:05.812>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2014-03-31.23:17:05.813>
closer = 'asvetlov'
components = []
creation = <Date 2012-12-18.20:07:22.419>
creator = 'asvetlov'
dependencies = []
files = ['34669']
hgrepos = []
issue_num = 16716
keywords = ['patch']
message_count = 14.0
messages = ['177704', '177706', '177711', '177712', '177713', '215272', '215273', '215274', '215275', '215279', '215280', '215282', '215284', '215285']
nosy_count = 5.0
nosy_names = ['pitrou', 'eric.araujo', 'r.david.murray', 'asvetlov', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue16716'
versions = ['Python 3.4', 'Python 3.5']
    @asvetlov
    Copy link
    Contributor Author

    The list of aliases is: IOError, EnvironmentError, WindowsError, mmap.error, socket.error, os.error and select.error

    Documentation should have deprecation message guessing to use OSError instead.

    @pitrou
    Copy link
    Member

    pitrou commented Dec 18, 2012

    "The following exceptions are kept for compatibility with previous versions; starting from Python 3.3, they are aliases of OSError."

    Do you want to add an explicit compatibility statement there?

    @asvetlov
    Copy link
    Contributor Author

    Don't know about library/exceptions.rst
    For other modules (socket, select etc.) I like to use ".. deprecated:: 3.3" markup.

    Antoine, do you have objections?

    @pitrou
    Copy link
    Member

    pitrou commented Dec 18, 2012

    No objections from me. It would be good to have other people's opinions, though.

    @bitdancer
    Copy link
    Member

    It seems sensible to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 31, 2014

    New changeset 5ad1d523b342 by Andrew Svetlov in branch 'default':
    Merge 3.4 (bpo-16716)
    http://hg.python.org/cpython/rev/5ad1d523b342

    @asvetlov
    Copy link
    Contributor Author

    Pushed. Thanks, priya

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 31, 2014

    New changeset c0c17718301f by Andrew Svetlov in branch 'default':
    Merge 3.4 (bpo-16716)
    http://hg.python.org/cpython/rev/c0c17718301f

    @asvetlov
    Copy link
    Contributor Author

    Close the issue after #f5dda52a4ccd and #8d5f005a0da3

    @pitrou
    Copy link
    Member

    pitrou commented Mar 31, 2014

    Andrew, please revert this. The modify() method is deprecated, so the "deprecated" markup is inappropriate here.

    @pitrou pitrou reopened this Mar 31, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Mar 31, 2014

    Oops, trying again: The modify() method is not deprecated, so the "deprecated" markup is inappropriate here.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 31, 2014

    New changeset 7b219429c404 by Andrew Svetlov in branch '3.4':
    bpo-16716: remove deprecation warning
    http://hg.python.org/cpython/rev/7b219429c404

    New changeset 1c6c2ec8916a by Andrew Svetlov in branch 'default':
    bpo-16716: remove deprecation warning
    http://hg.python.org/cpython/rev/1c6c2ec8916a

    @asvetlov
    Copy link
    Contributor Author

    The "deprecated markup" is removed. Sorry.
    Thanks to quick report.

    On Tue, Apr 1, 2014 at 2:08 AM, Roundup Robot <report@bugs.python.org> wrote:

    Roundup Robot added the comment:

    New changeset 7b219429c404 by Andrew Svetlov in branch '3.4':
    bpo-16716: remove deprecation warning
    http://hg.python.org/cpython/rev/7b219429c404

    New changeset 1c6c2ec8916a by Andrew Svetlov in branch 'default':
    bpo-16716: remove deprecation warning
    http://hg.python.org/cpython/rev/1c6c2ec8916a

    ----------

    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue16716\>

    @asvetlov
    Copy link
    Contributor Author

    Close the issue again after fixing Antoine's objection.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @asvetlov @bitdancer @pitrou