Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up importlib for Python 3.4 #59846

Closed
brettcannon opened this issue Aug 13, 2012 · 7 comments
Closed

Clean up importlib for Python 3.4 #59846

brettcannon opened this issue Aug 13, 2012 · 7 comments
Assignees
@brettcannon
Labels
type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

BPO 15641
Nosy @brettcannon, @ncoghlan, @asvetlov, @ericsnowcurrently
Files
  • issue15641.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
closed_at = <Date 2012-11-05.07:35:37.195>
created_at = <Date 2012-08-13.20:00:34.953>
labels = ['type-feature']
title = 'Clean up importlib for Python 3.4'
updated_at = <Date 2012-11-05.07:35:37.192>
user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2012-11-05.07:35:37.192>
actor = 'asvetlov'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2012-11-05.07:35:37.195>
closer = 'asvetlov'
components = []
creation = <Date 2012-08-13.20:00:34.953>
creator = 'brett.cannon'
dependencies = []
files = ['27852']
hgrepos = []
issue_num = 15641
keywords = ['patch']
message_count = 7.0
messages = ['168140', '172179', '172478', '174614', '174648', '174872', '174873']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'ncoghlan', 'Arfrever', 'asvetlov', 'python-dev', 'eric.snow', 'lyapun']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue15641'
versions = ['Python 3.4']
    @brettcannon
    Copy link
    Member Author

    importlib.abc.PyLoader and importlib.abc.PyPycLoader were both deprecated in 3.2 and slated for removal in Python 3.4. There is also some os2 stuff in importlib._bootstrap which can go as PEP-11 has os2 support slated for removal in Python 3.4.

    @brettcannon brettcannon self-assigned this Aug 13, 2012
    @asvetlov
    Copy link
    Contributor

    asvetlov commented Oct 6, 2012

    What's about Finder?
    Do you want to remove it also?

    @brettcannon
    Copy link
    Member Author

    Finder is only documented as deprecated; actually making it work with a reasonable warning is too much of a pain for such little gain. So it can just stay in as there is no maintenance burden.

    @lyapun
    Copy link
    Mannequin

    lyapun mannequin commented Nov 3, 2012

    Deleted code, docs, tests, and tests related stuff (like mocks). Test passes.

    @brettcannon
    Copy link
    Member Author

    Thanks for the patch, Taras! It looks good and I will apply it when I have time (or some other core dev beats me to it).

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 5, 2012

    New changeset 48228fb874c1 by Andrew Svetlov in branch 'default':
    Issue bpo-15641: Clean up deprecated classes from importlib
    http://hg.python.org/cpython/rev/48228fb874c1

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Nov 5, 2012

    Thanks, Taras.

    @asvetlov asvetlov closed this as completed Nov 5, 2012
    @asvetlov asvetlov added the type-feature A feature request or enhancement label Nov 5, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @brettcannon brettcannon

    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @asvetlov