Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lll.py can't handle multiple parameters correctly #58751

Closed
carton mannequin opened this issue Apr 11, 2012 · 9 comments
Closed

lll.py can't handle multiple parameters correctly #58751

carton mannequin opened this issue Apr 11, 2012 · 9 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@carton
Copy link
Mannequin

carton mannequin commented Apr 11, 2012

BPO 14546
Nosy @vstinner, @bitdancer, @serhiy-storchaka, @ZackerySpytz
PRs
  • bpo-14546: Fix the argument handling in Tools/scripts/lll.py #13026
  • [3.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) #13060
  • [2.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) #13063
    		•
    Files
  • lll.py.patch: Patch file
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-02.19:30:04.230>
created_at = <Date 2012-04-11.14:29:36.219>
labels = ['3.8', 'type-bug', '3.7']
title = "lll.py can't handle multiple parameters correctly"
updated_at = <Date 2019-05-02.19:30:04.229>
user = 'https://bugs.python.org/carton'

    bugs.python.org fields:

    activity = <Date 2019-05-02.19:30:04.229>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-02.19:30:04.230>
closer = 'vstinner'
components = ['Demos and Tools']
creation = <Date 2012-04-11.14:29:36.219>
creator = 'carton'
dependencies = []
files = ['25178']
hgrepos = []
issue_num = 14546
keywords = ['patch']
message_count = 9.0
messages = ['158036', '158037', '341161', '341269', '341275', '341276', '341308', '341309', '341310']
nosy_count = 5.0
nosy_names = ['vstinner', 'r.david.murray', 'serhiy.storchaka', 'carton', 'ZackerySpytz']
pr_nums = ['13026', '13060', '13063']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14546'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8']
    @carton
    Copy link
    Mannequin Author

    carton mannequin commented Apr 11, 2012

    Space errors in calling of lll(arg) of main() cause it only applies to the last parameter instead of all parameters.

    Patch attached for Python 3.1

    @bitdancer
    Copy link
    Member

    Thanks for the patch.

    Do you have any interest in writing a test for this? Tests for tools go in Lib/test/test_tools.py.

    @bitdancer bitdancer added the type-bug An unexpected behavior, bug, or error label Apr 11, 2012
    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Apr 30, 2019

    I've created a PR for this issue (with a test).

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes labels Apr 30, 2019
    @serhiy-storchaka
    Copy link
    Member

    New changeset c4e78b1 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
    bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026)
    c4e78b1

    @vstinner
    Copy link
    Member

    vstinner commented May 2, 2019

    test_tools: test_lll_multiple_dirs() failed on AMD64 Windows7 SP1 3.x: see bpo-36776.

    @vstinner
    Copy link
    Member

    vstinner commented May 2, 2019

    test_tools: test_lll_multiple_dirs() failed on AMD64 Windows7 SP1 3.x: see bpo-36776.

    I guess that the test should be decorated by @support.skip_unless_symlink or something like that.

    @vstinner
    Copy link
    Member

    vstinner commented May 2, 2019

    New changeset e85ba1e by Victor Stinner (Miss Islington (bot)) in branch '3.7':
    [3.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) (GH-13060)
    e85ba1e

    @vstinner
    Copy link
    Member

    vstinner commented May 2, 2019

    New changeset 7c2c01f by Victor Stinner (Zackery Spytz) in branch '2.7':
    [2.7] bpo-14546: Fix the argument handling in Tools/scripts/lll.py (GH-13026) (GH-13063)
    7c2c01f

    @vstinner
    Copy link
    Member

    vstinner commented May 2, 2019

    Thanks Carton He for the bug report, thanks Zackery Spytz for the fix, thanks Serhiy Storchaka for the review ;-)

    @vstinner vstinner closed this as completed May 2, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @bitdancer @serhiy-storchaka