-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for _msi.Record.GetString() and _msi.Record.GetInteger() #45443
Comments
Attached is a patch that adds the requested support. This is in relation http://www.gossamer-threads.com/lists/python/python/584264 In addition to the two methods I also "fixed" Fetch() by ensuring that If something further is required of me or I submitted this patch |
This patch appears to be mostly duplicated by patch 2125 which has been |
Yes, please do provide an updated patch. |
With apologies for the delay, I have modified the patch to remove the |
Martin, would this go in a bugfix release or is it a new feature for 3.3 only? |
I lost track what problem precisely this patch solves, so it's hard to tell whether it's a bug fix or not. |
All, I have trimmed this patch down to the bare minimum required to solve this problem. Please review this as I would dearly love to have this committed. The error received without this patch is MSIError: unknown error 103 This occurs when there are no more records to fetch from the view. The patch simply returns None when there are no more records to fetch -- similar to what is done by the DB API. |
Can someone review the latest patch please as it's only five additional lines of C code. |
I note that this patch has still not been accepted! Please let me know what needs to be done. I just tried against Python 3.4 and the patch works as expected -- other than the starting line number is now 715. I have signed the contributor agreement if that is what is holding things up. |
Sorry, I have no familiarity with msilib, _msi, or the internals of MSIs in general. The patch looks reasonably harmless to me, but I don't have the confidence to take responsibility for it. |
Will it be added to 3.6 also? |
Yes, I've created a backport PR: PR 4520
The dates for 3.6.4 release is listed at https://www.python.org/dev/peps/pep-0494/#id4 |
Thank you, Anthony. I added a test case and committed your patch to 3.6 and master branches. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: