This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: let make_buildinfo use a temporary directory on windows
Type: compile error Stage:
Components: Interpreter Core Versions: Python 3.2
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: brian.curtin, kristjan.jonsson, loewis
Priority: normal Keywords: patch

Created on 2010-09-29 06:28 by kristjan.jonsson, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
make_buildinfo.patch kristjan.jonsson, 2010-09-29 09:19 review
Messages (9)
msg117576 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2010-09-29 06:28
make_buildinfo currently creates temporary files getbuildinfo2.c and getbuildinfo.o in the current build directory.  This update allows the caller to specify a temp directory to put those files in.
The PCBuild pythoncore.vcproj now makes use of this, to put the.c and .o files in the current temporary directory $(IntDir).

This makes it possible to compile multiple project configurations in parallel, with tools such as incredibuild, without fearing that each will trample the other's getbuildinfo files.

Also removed an unnecessary 64 bit config for make_buildinfo.
msg117587 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2010-09-29 09:19
Ooops, here is the patch.
msg119791 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2010-10-28 14:47
Why is the second parameter optional?
msg119835 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2010-10-29 00:54
For backwards compatibility, say with other build configurations (there is still rudimentary support for VS2005, 2003.)
msg120010 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-10-30 19:56
Is there a reason this removes the Release x64 configuration?
msg120011 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-10-30 19:58
Let me rephrase that: What makes the Release x64 configuration unnecessary, thus removed?
msg120021 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2010-10-30 21:06
make_buildinfo is always built and run as a 32-bit binary, so I think this part of the change is fine (though unrelated to the objective of the change).

I think the patch is fine.
msg120125 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2010-11-01 13:25
Yes, I took the liberty of removing the superfluous build configuration as well, thereby simplifying the .sln and the build dependency graph.
The patch is for python 2.7.  Even though it's technically not a python patch but a build patch, I'll rework it for 3.2 and submit it.
msg120325 - (view) Author: Kristján Valur Jónsson (kristjan.jonsson) * (Python committer) Date: 2010-11-03 13:57
Committed to 3.2 in revision 86137
History
Date User Action Args
2022-04-11 14:57:07adminsetgithub: 54190
2010-11-03 13:57:42kristjan.jonssonsetstatus: open -> closed
resolution: accepted
messages: + msg120325

versions: + Python 3.2, - Python 2.7
2010-11-01 13:25:28kristjan.jonssonsetmessages: + msg120125
2010-10-30 21:06:22loewissetmessages: + msg120021
2010-10-30 19:58:11brian.curtinsetmessages: + msg120011
2010-10-30 19:56:40brian.curtinsetnosy: + brian.curtin
messages: + msg120010
2010-10-29 00:54:20kristjan.jonssonsetmessages: + msg119835
2010-10-28 14:47:03loewissetmessages: + msg119791
2010-10-28 10:56:15pitrousetnosy: + loewis
2010-09-29 09:19:53kristjan.jonssonsetfiles: + make_buildinfo.patch
keywords: + patch
messages: + msg117587
2010-09-29 06:28:36kristjan.jonssoncreate