➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010-09-07 13:44 by brian.curtin, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| review_email.txt | brian.curtin, 2010-09-07 13:44 | |||
| issue9790_fix.diff | brian.curtin, 2010-09-23 23:50 | |||
| Messages (6) | |||
|---|---|---|---|
| msg115761 - (view) | Author: Brian Curtin (brian.curtin) *  |
Date: 2010-09-07 13:44 | |
As pointed out by Nick Coghlan on python-dev, ntpath.samefile and ntpath.sameopenfile are vulnerable to deadlock because they contain imports. |
|||
| msg117232 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-09-23 20:39 | |
Committed to py3k in r84988 using Nick's second suggestion. |
|||
| msg117247 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-09-23 23:50 | |
Nick noticed another issue with this, and it actually won't work on pre-Vista versions since we load GetFinalPathNameByHandle at runtime, which is why we had that NotImplementedError. Attaching a patch which should handle this. We only try the import on Windows 6.0 or above now, and otherwise (XP, other OS'es) use the fallback method. |
|||
| msg117283 - (view) | Author: Nick Coghlan (ncoghlan) * |
Date: 2010-09-24 13:37 | |
Yeah, I realised shortly after I sent my email in response to the checkin that the original version was covering more cases in that first try-block. I'll defer to you when it comes to exactly which case that NotImplementedError was covering - patch looks good given the explanation. |
|||
| msg117284 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2010-09-24 13:56 | |
Patch looks ok, and it would hopefully fix build errors on the XP buildbots :) |
|||
| msg117285 - (view) | Author: Brian Curtin (brian.curtin) * |
Date: 2010-09-24 13:57 | |
Committed in r84992. Thanks for having a look. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:06 | admin | set | github: 53999 |
| 2010-09-24 13:57:55 | brian.curtin | set | status: open -> closed resolution: fixed messages: + msg117285 stage: patch review -> resolved |
| 2010-09-24 13:56:05 | pitrou | set | nosy:
+ pitrou messages: + msg117284 |
| 2010-09-24 13:37:46 | ncoghlan | set | messages: + msg117283 |
| 2010-09-23 23:50:16 | brian.curtin | set | status: closed -> open files: + issue9790_fix.diff keywords: + patch nosy: + ncoghlan messages: + msg117247 resolution: fixed -> (no value) stage: resolved -> patch review |
| 2010-09-23 20:41:13 | brian.curtin | set | status: open -> closed |
| 2010-09-23 20:39:54 | brian.curtin | set | resolution: fixed messages: + msg117232 stage: needs patch -> resolved |
| 2010-09-07 13:44:01 | brian.curtin | create | |