Issue978662
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2004-06-24 01:56 by brett.cannon, last changed 2022-04-11 14:56 by admin. This issue is now closed.
Messages (5) | |||
---|---|---|---|
msg21273 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2004-06-24 01:56 | |
Line 412 of Modules/_localemodule.c calls PyMac_getscript() which is within a ``#if defined(__APPLE__)`` block. Trouble is that the code is in Python/mactoolboxglue.c which is not compiled if -- disable-toolbox-glue is a compile option (which it was on my OS X 10.3.4 box). Probably shouldn't have a compile failure thanks to ld not finding the symbol; should probably either just not compile the module, change the #if block, or change the function. |
|||
msg21274 - (view) | Author: Jack Jansen (jackjansen) * ![]() |
Date: 2004-06-25 11:56 | |
Logged In: YES user_id=45365 There are two solutions: 1) Move PyMac_getscript() to _localemodule. 2) Copy PyMac_getscript() to _localemodule. 3) #ifdef PyLocale_getdefaultlocale in _localemodule on something set by enable_toolbox_module_glue. 1) means we can't really put the external declaration in macglue.h any more (_localemodule needn't be configured), but I don't think it's used by anything but localemodule, so it's probably the best solution. Still, this is an incompatible change, so we shouldn't backport it. |
|||
msg21275 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2004-06-26 03:41 | |
Logged In: YES user_id=357491 grep agrees with you, Jack: drifty@Bretts-Computer>grep -rl PyMac_getscript * Include/pymactoolbox.h Modules/_localemodule.c Python/mactoolboxglue.c So we could just copy and paste it (and fix the spelling of Fredrik's last name =). But will those CF* functions be linked properly w/o a framework build? I didn't see any macro definitions or anything to signal when a toolbox glue build was being done, but it would not hurt to define that. I get a ton of linking errors for any module that has Carbon with this ``-- disable-framework --disable-toolbox-glue`` build that I have been fiddling with. Should we try to make it so that those modules are built only if some flag is set somewhere signifying that the proper OS X- specific build options are not turned off? Or am I just being so totally non-standard with these build options (only done to try to build faster on my old iBook) that it is not worth the hassle? |
|||
msg21276 - (view) | Author: Jack Jansen (jackjansen) * ![]() |
Date: 2004-07-15 13:32 | |
Logged In: YES user_id=45365 Ok, I've checked in the changes. I'm assigning to you so you can check that a --disable-toolbox-glue build still works, please close this report if it does. |
|||
msg21277 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2004-07-19 01:13 | |
Logged In: YES user_id=357491 OK, all looks good. Thanks, Jack. |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:56:05 | admin | set | github: 40443 |
2004-06-24 01:56:08 | brett.cannon | create |