classification
Title: Unittests for Lib/rlcompleter.py
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.1, Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ezio.melotti, maker, mark.dickinson, pitrou, r.david.murray
Priority: normal Keywords: patch

Created on 2010-08-03 17:29 by maker, last changed 2010-08-04 15:57 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
testrlcompleter.patch maker, 2010-08-04 03:49 test rlcompleter.py
Messages (4)
msg112636 - (view) Author: Michele Orrù (maker) * Date: 2010-08-03 17:29
The attached patch tests Lib/rlcompleter.py.
msg112640 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-08-03 18:07
From a quick look the patch looks nice, thanks!
There's a typo ("builtinis namespace").
msg112646 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2010-08-03 18:23
The new tests pass on OS X, using both GNU readline (v6.1) and the system libedit.
msg112826 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-08-04 15:57
Thank you! I've committed your patch in py3k (r83719) and backported it to 3.1 (r83723) and 2.7 (r83725) since it's always nice to have better tests.
History
Date User Action Args
2010-08-04 15:57:46pitrousetstatus: open -> closed
resolution: fixed
messages: + msg112826

stage: patch review -> resolved
2010-08-04 03:49:35makersetfiles: + testrlcompleter.patch
2010-08-04 03:49:13makersetfiles: - testrlcompleter.patch
2010-08-03 18:23:50mark.dickinsonsetnosy: + mark.dickinson
messages: + msg112646
2010-08-03 18:07:29pitrousetnosy: + r.david.murray

type: enhancement -> behavior
stage: patch review
2010-08-03 18:07:02pitrousetnosy: + pitrou

messages: + msg112640
versions: + Python 3.1, Python 2.7
2010-08-03 17:29:57makercreate