classification
Title: pulldom doesn't provide END_DOCUMENT or COMMENT nodes.
Type: behavior Stage: patch review
Components: XML Versions: Python 3.2
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: eric.araujo, flomm, mark.smith, scoder
Priority: normal Keywords: patch

Created on 2010-07-24 13:01 by mark.smith, last changed 2019-05-30 20:00 by cheryl.sabella.

Files
File name Uploaded Description Edit
test_pulldom.py mark.smith, 2010-07-24 13:01 A TestCase to demonstrate this issue.
pulldom_enddoc_event_fix.patch flomm, 2012-03-11 21:25 bugfix for ENDDOCUMENT event review
Pull Requests
URL Status Linked Edit
PR 10328 closed Jonathan.Gossage, 2018-11-05 13:37
Messages (3)
msg111474 - (view) Author: Mark Smith (mark.smith) * Date: 2010-07-24 13:01
I've been developing unit tests to increase the code coverage for pulldom, and have discovered that comments and end_document do not appear to result in events being obtained from the DOMEventStream.

I've attached a failing TestCase to demonstrate this.
msg111486 - (view) Author: √Čric Araujo (eric.araujo) * (Python committer) Date: 2010-07-24 14:47
I tried looking at the doc to see if this was by design, and well, pulldom docs :) So I looked at the code, same thing, and finally read the commit history. It appears that pulldom is supposed to be DOM-compliant, so go ahead in adding unit tests for that and fixing it.
msg155409 - (view) Author: Florian Mladitsch (flomm) Date: 2012-03-11 21:25
I found the bug for the end_document event and fixed it. But I couldn't figure out why the PullDOM class did not have comment-events.
History
Date User Action Args
2019-05-30 20:00:25cheryl.sabellasetnosy: + scoder
2018-11-05 13:37:24Jonathan.Gossagesetpull_requests: + pull_request9635
2016-01-16 00:22:42martin.pantersetstage: patch review
2012-03-11 21:25:46flommsetfiles: + pulldom_enddoc_event_fix.patch

nosy: + flomm
messages: + msg155409

keywords: + patch
2010-07-24 14:47:18eric.araujosetnosy: + eric.araujo
messages: + msg111486
2010-07-24 13:01:50mark.smithcreate