This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Tests for leapdays in module
Type: Stage: resolved
Components: Tests Versions: Python 3.1, Python 3.2, Python 2.7
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: Nosy List: John.Chandler, r.david.murray, sandro.tosi
Priority: normal Keywords: patch

Created on 2010-07-23 18:58 by John.Chandler, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
test_calendar.diff John.Chandler, 2010-07-23 18:58 review
Messages (3)
msg111373 - (view) Author: John Chandler (John.Chandler) Date: 2010-07-23 18:58

Attaching a patch for the file.

Adds four tests to provide coverage of the leapdays() function.

msg124969 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2010-12-31 17:23
I just tried John's patch, and:

- it still applies without problem (except for a bit of offset)
- I can confirm that it actually adds test coverage for leapdays() function (bringing calendar coverage from 71% to 72%).

I think it would be good to apply it to py3k branch.

msg124974 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-12-31 19:32
Applied in r87590.  I threw in an extra test for a multi-leapyear-range.  Since there was no reason not to, I backported it to 3.1 in r87591 and 2.7 in r87592.  In the latter two commits I also backported the issue 9342 patch.

Thanks for the patch, John, and for the review, Sandro.
Date User Action Args
2022-04-11 14:57:04adminsetgithub: 53607
2010-12-31 19:32:43r.david.murraysetstatus: open -> closed

versions: + Python 3.1, Python 2.7
nosy: + r.david.murray

messages: + msg124974
resolution: accepted
stage: patch review -> resolved
2010-12-31 17:23:12sandro.tosisetnosy: + sandro.tosi

messages: + msg124969
stage: patch review
2010-07-23 18:58:41John.Chandlercreate