classification
Title: test_support.transient_internet fails on Freebsd because socket has no attribute EAI_NODATA
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.1, Python 3.2, Python 2.7, Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: r.david.murray Nosy List: r.david.murray, vstinner
Priority: normal Keywords: patch

Created on 2010-06-03 18:50 by r.david.murray, last changed 2010-12-27 16:51 by r.david.murray. This issue is now closed.

Files
File name Uploaded Description Edit
transient_internet.patch r.david.murray, 2010-06-03 18:50 review
transient_internet.patch r.david.murray, 2010-06-03 19:53 review
transient_internet.patch r.david.murray, 2010-06-03 20:02 review
Messages (6)
msg106972 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-06-03 18:50
test_support.transient_internet was modified to check for more errors, but one of them, socket.EAI_NODATA, is not supported by FreeBSD.  The attached patch rewrites transient_internet to only test EAI error codes that exist, and also improves the skip message.
msg106975 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-06-03 19:28
Modified patch based on feedback from Antoine Pitrou on #python-dev.
msg106978 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-06-03 19:53
A somewhat more clever version.
msg106979 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-06-03 20:02
Final version after more feedback.
msg106981 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-06-03 20:21
Committed to trunk in r81678.  I'll wait until the trunk buildbots show the test_ssl and test_urllib2net error clear before back/forward porting.
msg124712 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2010-12-27 16:51
I never forward ported this, but it was fixed in a different way in python3 during a complete rewrite of transient_internet for other reasons.
History
Date User Action Args
2010-12-27 16:51:44r.david.murraysetstatus: open -> closed

messages: + msg124712
resolution: fixed
stage: commit review -> resolved
2010-06-03 20:21:11r.david.murraysetmessages: + msg106981
stage: commit review
2010-06-03 20:02:26r.david.murraysetfiles: + transient_internet.patch

messages: + msg106979
2010-06-03 19:53:23r.david.murraysetfiles: + transient_internet.patch

messages: + msg106978
2010-06-03 19:41:22r.david.murraysetfiles: - transient_internet.patch
2010-06-03 19:28:39r.david.murraysetfiles: + transient_internet.patch

messages: + msg106975
2010-06-03 18:50:58r.david.murraysetassignee: r.david.murray
2010-06-03 18:50:04r.david.murraycreate