This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: PyUnicode_CompareWithASCIIString name is not mangled (UCS2, UCS4)
Type: Stage:
Components: Unicode Versions: Python 3.2
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: loewis, vstinner
Priority: normal Keywords: patch

Created on 2010-05-18 23:50 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
pyunicode_compareascii.patch vstinner, 2010-05-18 23:50
Messages (3)
msg106015 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-05-18 23:50
In unicodeobject.h, you can see:

# define PyUnicode_CompareWithASCII PyUnicodeUCS2_CompareASCII
# define PyUnicode_CompareWithASCII PyUnicodeUCS4_CompareWithASCII
PyAPI_FUNC(int) PyUnicode_CompareWithASCIIString(
    PyObject *left,
    const char *right

The defines miss the String suffix :-/

Attached patch adds the suffix but I guess that it breaks backward compatibility. Is it a problem to apply this patch in Python 3.2 (but not in Python 3.1)?
msg106039 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2010-05-19 06:23
It's fine to apply to 3.2.
msg119529 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-10-24 20:38
Fixed by r85827.
Date User Action Args
2022-04-11 14:57:01adminsetgithub: 53007
2010-10-24 20:38:50vstinnersetstatus: open -> closed
resolution: accepted -> fixed
messages: + msg119529
2010-05-19 06:23:59loewissetresolution: accepted

messages: + msg106039
nosy: + loewis
2010-05-18 23:50:21vstinnercreate