➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010-05-01 01:15 by alex, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue8585.diff | berker.peksag, 2012-11-18 19:12 | review | ||
| Issue8585.patch | BreamoreBoy, 2014-07-02 07:21 | Original patch no longer applied | review | |
| Messages (8) | |||
|---|---|---|---|
| msg104684 - (view) | Author: Alex Gaynor (alex) *  |
Date: 2010-05-01 01:15 | |
There are no tests for zipimporter.find_module in the success case, only tests that it handles invalid inputs ok. I'll work up some tests for this tomorrow probably. |
|||
| msg113041 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2010-08-05 20:29 | |
Since devs are trying to improve tests, I expect a patch will get looked at. |
|||
| msg113043 - (view) | Author: Alex Gaynor (alex) * |
Date: 2010-08-05 20:33 | |
Gah, I lost track of this one after I realized the bug I was chasing after (originally thought to be in PyPy's zipimpoter) was actually in Django. I'll try to get to this over the weekend. |
|||
| msg175776 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2012-11-17 17:07 | |
Been longer than a weekend. =) |
|||
| msg175906 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2012-11-18 19:12 | |
I've attached a patch that adds tests for the zipimporter.find_module(). |
|||
| msg222080 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2014-07-02 07:21 | |
I've just reworked Berker's patch as it no longer applied. On Windows 7 before and after applying the patch both test runs gave me 49 tests, 2 skipped. Can we have a commit review please. |
|||
| msg247124 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2015-07-22 14:58 | |
New changeset ef5c5a2bbd48 by Robert Collins in branch 'default': Issue #8585: improved tests for zipimporter2. Patch from Mark Lawrence. https://hg.python.org/cpython/rev/ef5c5a2bbd48 |
|||
| msg247126 - (view) | Author: Robert Collins (rbcollins) * |
Date: 2015-07-22 14:59 | |
Applied to 3.6 only. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:00 | admin | set | github: 52831 |
| 2015-07-22 14:59:24 | rbcollins | set | status: open -> closed versions: + Python 3.6, - Python 3.5 nosy: + rbcollins messages: + msg247126 resolution: fixed stage: commit review -> resolved |
| 2015-07-22 14:58:13 | python-dev | set | nosy:
+ python-dev messages: + msg247124 |
| 2014-07-10 15:49:04 | berker.peksag | set | versions: - Python 3.4 |
| 2014-07-02 18:30:08 | brett.cannon | set | assignee: berker.peksag |
| 2014-07-02 09:04:07 | Claudiu.Popa | set | stage: needs patch -> commit review versions: + Python 3.5, - Python 3.2, Python 3.3 |
| 2014-07-02 07:21:11 | BreamoreBoy | set | files:
+ Issue8585.patch nosy: + BreamoreBoy messages: + msg222080 |
| 2012-11-18 19:12:26 | berker.peksag | set | files:
+ issue8585.diff versions: + Python 3.2, Python 3.3 nosy: + berker.peksag messages: + msg175906 keywords: + patch |
| 2012-11-17 17:33:32 | brett.cannon | set | versions: - Python 2.7, Python 3.2, Python 3.3 |
| 2012-11-17 17:24:55 | terry.reedy | set | versions: + Python 3.3, Python 3.4, - Python 3.1 |
| 2012-11-17 17:07:19 | brett.cannon | set | messages: + msg175776 |
| 2010-08-05 20:33:17 | alex | set | messages: + msg113043 |
| 2010-08-05 20:29:10 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg113041 versions: - Python 2.6 |
| 2010-05-01 01:16:46 | pitrou | set | versions:
+ Python 2.6, Python 3.1, Python 2.7, Python 3.2 nosy: + brett.cannon, ncoghlan components: + Tests, - Extension Modules type: behavior stage: needs patch |
| 2010-05-01 01:15:35 | alex | create | |