This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Support new features of ZLIB 1.2.7
Type: enhancement Stage: resolved
Components: Versions: Python 3.3
process
Status: closed Resolution: postponed
Dependencies: Superseder:
Assigned To: Nosy List: Arfrever, Jason.Killen, Todd.Rovito, abhishek_bits, giampaolo.rodola, jcea, nadeem.vawda, zach.ware
Priority: normal Keywords:

Created on 2010-04-26 17:23 by jcea, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (13)
msg104254 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2010-04-26 17:23
Zlib 1.2.5 adds new features like "inflateReset2()", "inflateMark()", or "Z_TREES" flags.

We should support them if we have zlib 1.2.5 installed.

I think the patch is trivial, beside testing that we have a recent zlib version.
msg104256 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2010-04-26 17:30
Relevant links:

http://www.zlib.net/
http://www.zlib.net/manual.html


My mistake: these new features were added in zlib 1.2.4, not 1.2.5.
msg104284 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2010-04-26 22:29
Do you intend to provide a patch?
msg104289 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2010-04-26 23:25
I am documenting a "need" and marking it as "easy".

If somebody else want to work on this, perfect. If not, I would adopt it in the future, and provide a patch myself. I rather prefer the first option, and I think is a good issue for a newbie (with C knowledge).

Let's say this issue is a "to be done". Creating the issue will prevent me to forget about modern zlib support in Python. But if anybody else step forward, I will be glad :).
msg152088 - (view) Author: abhishek (abhishek_bits) Date: 2012-01-27 12:21
I think New features like "inflateReset2()", "inflateMark()", or "Z_TREES" flags are included in python 3.2.2.
msg152089 - (view) Author: Nadeem Vawda (nadeem.vawda) * (Python committer) Date: 2012-01-27 12:37
No, the latest revision of Modules/zlibmodule.c doesn't use any of these
new features.
msg152115 - (view) Author: abhishek (abhishek_bits) Date: 2012-01-27 20:14
Check This out
http://hg.python.org/cpython/file/b99c54acb22d/Modules/zlib/inflate.c
http://hg.python.org/cpython/file/b99c54acb22d/Modules/zlib/zconf.h
http://hg.python.org/cpython/file/b99c54acb22d/Modules/zlib/zconf.in.h

All three files contain these functions
msg152127 - (view) Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) * (Python triager) Date: 2012-01-27 21:46
Modules/zlib directory contains only bundled copy of zlib-1.2.5.
zlib Python module uses Modules/zlibmodule.c file.
msg155630 - (view) Author: Jason Killen (Jason.Killen) * Date: 2012-03-13 16:38
Given this is marked as good for a newbie and easy I figured I'd take a crack at it but I'm confused.  As example I don't see where inflateReset2 would be useful.  I don't see anywhere inflateReset is used and would need to be replaced by inflateReset2.  I also don't see where the action of inflateReset2 (End then Init) is currently used.  What am I missing?
msg155796 - (view) Author: Nadeem Vawda (nadeem.vawda) * (Python committer) Date: 2012-03-14 21:36
Jesús, did you have any particular idea about exactly where these new
features would be useful? Or was your idea that someone needs to read
through the code and check whether the features can be used at all?

Also, it should be noted that the scope of this issue has grown somewhat
since it was created - zlib 1.2.6 was released recently, with more new
features. And it seems that the zlib folks sometimes add new features in
point releases (e.g. 1.2.5.1) as well...
msg158654 - (view) Author: Jesús Cea Avión (jcea) * (Python committer) Date: 2012-04-18 20:06
Nadeem Vawda:

> Jesús, did you have any particular idea about exactly where these new
> features would be useful? Or was your idea that someone needs to read
> through the code and check whether the features can be used at all?

Yes, my idea was for somebody to evaluate new features in ZLIB and make them accessible from Python.
msg158729 - (view) Author: Jason Killen (Jason.Killen) * Date: 2012-04-19 13:58
Given I'm new I wouldn't say I "evaluated" the usefulness of the new functions but I have given them a look and didn't see anything obvious.  If thats good enough great, if not then hopefully someone with a little more experience will take a look.
msg367314 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2020-04-26 16:51
In the intervening 8 years since there was last activity in this issue, zlib 1.2.11 has been released and probably has even more new features.  However, I think rather than looking for new features to implement, we should create specific issues to implement new features as use cases for them come up; chances are, some of these have already happened without reference to this isuse.  As such, I'm going to go ahead and close this issue.
History
Date User Action Args
2022-04-11 14:57:00adminsetgithub: 52782
2020-04-26 16:51:38zach.waresetstatus: open -> closed

nosy: + zach.ware
messages: + msg367314

resolution: postponed
stage: resolved
2012-05-03 21:33:58Arfreversettitle: Support new features of ZLIB 1.2.6 -> Support new features of ZLIB 1.2.7
2012-04-19 13:58:24Jason.Killensetmessages: + msg158729
2012-04-18 20:06:45jceasettitle: Support new features of ZLIB 1.2.4 -> Support new features of ZLIB 1.2.6
2012-04-18 20:06:21jceasetmessages: + msg158654
2012-04-11 11:15:40loewissetkeywords: - easy
2012-03-14 21:36:06nadeem.vawdasetmessages: + msg155796
2012-03-13 16:38:12Jason.Killensetnosy: + Jason.Killen
messages: + msg155630
2012-01-27 21:46:07Arfreversetnosy: + Arfrever

messages: + msg152127
versions: + Python 3.3, - Python 3.2
2012-01-27 20:14:38abhishek_bitssetmessages: + msg152115
2012-01-27 12:37:55nadeem.vawdasetmessages: + msg152089
2012-01-27 12:21:39abhishek_bitssetnosy: + abhishek_bits
messages: + msg152088
2012-01-26 13:04:16nadeem.vawdasetnosy: + nadeem.vawda
2010-08-02 00:54:28Todd.Rovitosetnosy: + Todd.Rovito
2010-04-26 23:25:00jceasetmessages: + msg104289
2010-04-26 22:29:44giampaolo.rodolasetnosy: + giampaolo.rodola
messages: + msg104284
2010-04-26 17:31:01jceasettitle: Support new features of ZLIB 1.2.5 -> Support new features of ZLIB 1.2.4
2010-04-26 17:30:35jceasetmessages: + msg104256
2010-04-26 17:23:08jceacreate