This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: build-installer fix for setIcon when no script path specified
Type: compile error Stage: resolved
Components: macOS Versions: Python 3.1, Python 3.2, Python 3.3, Python 2.7, Python 2.6
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: ronaldoussoren Nosy List: db3l, ronaldoussoren
Priority: normal Keywords: patch

Created on 2010-04-20 22:57 by db3l, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
build-installer.diff db3l, 2010-04-20 22:57
Messages (3)
msg103791 - (view) Author: David Bolen (db3l) * Date: 2010-04-20 22:57
The attached suggested patch fixes a small bug where if you execute the build-installer script without an explicit path (e.g., "python") the setIcon compilation will fail since dirname(__file__) is an empty string, so it ends up looking for files beneath "/".

It also normalizes the function slightly, since part of the previous code explicitly used dirname(__file__) whereas part of the code just assumed the output directory was relative to the current directory.
msg104500 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-04-29 13:02
The patch looks good, I will apply it over the weekend.

Thanks for looking into this.
msg104642 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-04-30 15:01
Committed in r80653 (trunk), r80654 (2.6), r80655 (3.2) and r80656 (3.1)
Date User Action Args
2022-04-11 14:57:00adminsetgithub: 52722
2010-04-30 15:01:45ronaldoussorensetstatus: open -> closed
resolution: accepted
messages: + msg104642

stage: resolved
2010-04-29 13:02:26ronaldoussorensetmessages: + msg104500
2010-04-20 22:57:40db3lcreate