➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010-04-05 16:10 by dmalcolm, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| fix-test_gdb-whitespace-issues.txt | dmalcolm, 2010-04-05 16:10 | |||
| Messages (2) | |||
|---|---|---|---|
| msg102383 - (view) | Author: Dave Malcolm (dmalcolm)  |
Date: 2010-04-05 16:10 | |
test_gdb's get_gdb_repr carves up a gdb backtrace to try to extract how gdb representated the data. When connected to a tty, gdb will insert additional newlines and spaces based on the width of the tty (internally it has a wrap_here() function to do this), so the test turned out to be somewhat susceptible to whitespace and tty configuration. I'm attaching a patch against trunk which I believe fixes this. I've tested it with various tty widths (from 5 columns wide through to 235 columns wide), and redirecting to a file, and all tests pass. [Seen on buildbot on this run: http://www.python.org/dev/buildbot/builders/sparc%20Ubuntu%20trunk/builds/37/steps/test/logs/stdio and I believe this was the cause of all of four of the five failures there. The remaining one "test_corrupt_tp_name" seems to be a different issue] |
|||
| msg102384 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2010-04-05 16:32 | |
Committed in r79803. I changed the assert_ to an if not m/fail, since assert_ is deprecated and I think the if makes it clearer than the assert_ what it is that is being checked. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:59 | admin | set | github: 52563 |
| 2010-04-05 16:32:13 | r.david.murray | set | status: open -> closed priority: normal components: + Tests type: behavior nosy: r.david.murray, dmalcolm messages: + msg102384 resolution: fixed stage: patch review -> resolved |
| 2010-04-05 16:10:32 | dmalcolm | create | |