classification
Title: Missing #include guards
Type: compile error Stage:
Components: Interpreter Core Versions: Python 2.7
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: akuchling Nosy List: akrpic77, akuchling
Priority: normal Keywords: patch

Created on 2010-01-15 13:14 by akrpic77, last changed 2010-02-22 23:13 by akuchling. This issue is now closed.

Files
File name Uploaded Description Edit
missing_ifdef_s.patch akrpic77, 2010-01-15 13:14
Messages (2)
msg97809 - (view) Author: Andrej Krpic (akrpic77) Date: 2010-01-15 13:14
Patch provides consistency with include guards already present in core.
This issue is somehow next step to #1495999 and #1492356.
These headers are missing from MSVC when targeting MS Windows CE .

HAVE_PROCESS_H already used in:
Modules/posixmodule.c, Python/thread_nt.h

HAVE_SYS_TYPES_H already used in:
Modules/io/_iomodule.c, Objects/fileobject.c, ...

HAVE_SIGNAL_H already in:
Modules/posixmodule.c

HAVE_ERRNO_H already in:
Include/Python.h, Python/ceval.c, ...
DONT_HAVE_ERRNO_H is not used anywhere

HAVE_FCNTL_H already in:
Modules/posixmodule.c, Modules/socketmodule.c
msg99867 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2010-02-22 23:13
Thanks for this patch!  Committed the change to 2.7 trunk's fileobject.c as rev78345.  The changes to the other modules have been committed as rev78346.
History
Date User Action Args
2010-02-22 23:13:08akuchlingsetstatus: open -> closed

nosy: + akuchling
messages: + msg99867

assignee: akuchling
resolution: accepted
2010-01-15 13:14:19akrpic77create