Title: ElementTree: file locking in Jython 2.5 (OSError on Windows)
Type: behavior Stage: resolved
Components: Windows, XML Versions: Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: flox Nosy List: Christian.Henz, berker.peksag, flox, gdoutch, mjpieters, pjenvey, python-dev
Priority: normal Keywords: patch

Created on 2009-11-16 15:56 by gdoutch, last changed 2015-01-22 18:36 by berker.peksag. This issue is now closed.

File name Uploaded Description Edit
issue7334_etree_patch.diff flox, 2010-02-16 13:59 Patch, apply to trunk
Messages (10)
msg95349 - (view) Author: Gareth Doutch (gdoutch) Date: 2009-11-16 15:56
I have a problem with an xml file locking after read and/or write.

I have a short sample code with unit test available here:

Below are the
outputs from Jython and CPython (v 2.5.4).
I am using Jython 2.5.1 on Windows XP and java version "1.6.0_16".

ERROR: runTest (__main__.TestDelete)
Traceback (most recent call last):
  File "W:\testTeam\SIT\JySit\sit\scripts\", line 73, in tearDown
  File "C:\jython2.5.1\Lib\", line 342, in remove
    raise OSError(0, "couldn't delete file", path)
OSError: [Errno 0] couldn't delete file: 'C:\\testdir\\test.xml'
Ran 1 test in 0.454s
FAILED (errors=1)
Ran 1 test in 0.015s

The problem can be cured by applying the changes as per file:
msg95350 - (view) Author: Gareth Doutch (gdoutch) Date: 2009-11-16 16:02
This is on the Jython list:
msg99409 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2010-02-16 13:59
The patch proposed on msg95349:
 * need tests
 * not reviewed (yet)
msg102762 - (view) Author: Philip Jenvey (pjenvey) * (Python committer) Date: 2010-04-10 02:48
Patch with tests (which can only really test it on Windows) here
msg124621 - (view) Author: Philip Jenvey (pjenvey) * (Python committer) Date: 2010-12-24 23:53
Florent, any chance of signing off on this for 3.2? I was waiting for the patch to go through your authorized elementtree fork
msg146587 - (view) Author: Florent Xicluna (flox) * (Python committer) Date: 2011-10-29 01:09
Changeset cff78ffb932a fixed the issue for 3.2.
I will consider backporting.
msg146588 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-10-29 01:39
New changeset eceaa31252b3 by Florent Xicluna in branch '2.7':
Closes #7334: close source files on ElementTree.parse and iterparse (partial backport of issue #10093 from 3.2).
msg224713 - (view) Author: Christian Henz (Christian.Henz) Date: 2014-08-04 12:27
I think the cElementTree portion of the applied changes is incorrect. `close_source` is never actually set to `True`.
msg234490 - (view) Author: Martijn Pieters (mjpieters) * Date: 2015-01-22 12:45
Indeed, the 2.7 backport was not correctly applied for _elementtree.c, leaving files open because the close_source flag is set to False *again* when opening a filename.

Should a new issue be opened or should this ticket be re-opened?
msg234506 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-01-22 18:36
> Should a new issue be opened or should this ticket be re-opened?

It's a 3 years old backport, I'd say open a new issue.
Date User Action Args
2015-01-22 18:36:00berker.peksagsetnosy: + berker.peksag
messages: + msg234506
2015-01-22 12:45:52mjpieterssetnosy: + mjpieters
messages: + msg234490
2014-08-04 13:41:22brian.curtinsetnosy: - brian.curtin
2014-08-04 12:27:07Christian.Henzsetnosy: + Christian.Henz
messages: + msg224713
2011-10-29 01:39:41python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg146588

stage: patch review -> resolved
2011-10-29 01:09:28floxsetresolution: fixed
stage: needs patch -> patch review
messages: + msg146587
versions: - Python 3.2
2010-12-24 23:53:27pjenveysetassignee: pjenvey -> flox
messages: + msg124621
nosy: pjenvey, brian.curtin, flox, gdoutch
2010-04-10 02:49:55brian.curtinsetnosy: + brian.curtin
2010-04-10 02:48:45pjenveysetmessages: + msg102762
2010-02-16 13:59:10floxsetfiles: + issue7334_etree_patch.diff
priority: normal

title: XML file locking in Jython 2.5 (OSError on Windows) -> ElementTree: file locking in Jython 2.5 (OSError on Windows)
keywords: + patch
nosy: + flox

messages: + msg99409
stage: needs patch
2009-11-17 04:15:33pjenveysetassignee: pjenvey

nosy: + pjenvey
versions: + Python 2.7, Python 3.2, - Python 2.5
2009-11-16 16:02:56gdoutchsetmessages: + msg95350
2009-11-16 15:56:07gdoutchcreate