➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2009-10-27 18:27 by pitrou, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue7221.diff | jesstess, 2014-04-19 18:54 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg94570 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2009-10-27 18:27 | |
It changes the class variable `usepoll` from its parent to True, but that variable isn't used anywhere. |
|||
| msg216874 - (view) | Author: Jessica McKellar (jesstess) *  |
Date: 2014-04-19 18:54 | |
This looks like a copy-paste typo from test_asynchat, which does use `usepoll`. Attached is a patch that removes `usepoll` and a `DispatcherWithSendTests_UsePoll` TestCase that did nothing but set `usepoll=True`. * The diff passes `make patchcheck`. * The full test suite passes with this diff. |
|||
| msg216875 - (view) | Author: Roundup Robot (python-dev) |
Date: 2014-04-19 19:07 | |
New changeset cbe7b5a5a110 by Antoine Pitrou in branch 'default': Issue #7221: remove redundant tests in test_asyncore. Patch by Jessica McKellar. http://hg.python.org/cpython/rev/cbe7b5a5a110 |
|||
| msg216876 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-04-19 19:08 | |
Now committed. Thanks for the patch! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:54 | admin | set | github: 51470 |
| 2014-04-19 19:08:11 | pitrou | set | status: open -> closed versions: + Python 3.5, - Python 3.1, Python 2.7, Python 3.2 messages: + msg216876 resolution: fixed stage: patch review -> resolved |
| 2014-04-19 19:07:33 | python-dev | set | nosy:
+ python-dev messages: + msg216875 |
| 2014-04-19 18:54:10 | jesstess | set | files:
+ issue7221.diff nosy: + jesstess messages: + msg216874 keywords: + patch, needs review stage: needs patch -> patch review |
| 2011-03-26 15:49:44 | facundobatista | set | assignee: facundobatista -> |
| 2010-07-11 10:04:47 | BreamoreBoy | set | versions: - Python 2.6 |
| 2009-10-27 18:27:01 | pitrou | create | |