This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Some bug fixes for regular ex code.
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: effbot Nosy List: aimacintyre, effbot, glchapman, gvanrossum, herron, niemeyer, nnorwitz
Priority: normal Keywords: patch

Created on 2003-04-14 09:14 by herron, last changed 2022-04-10 16:08 by admin. This issue is now closed.

File name Uploaded Description Edit
sre-fixes-1 herron, 2003-04-14 09:14 Some bug fixes for regular ex code.
Messages (12)
msg43339 - (view) Author: Gary Herron (herron) Date: 2003-04-14 09:14
A small fix for bug #545855 and  Greg Chapman's 
addition of op code SRE_OP_MIN_REPEAT_ONE for 
eliminating recursion on simple uses of pattern '*?' on a 
long string. 
msg43340 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2003-04-14 16:46
Logged In: YES 

Will look at this ASAP.
msg43341 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2003-04-14 18:15
Logged In: YES 

Looks cool; I've checked this in unchanged, except changing
one comment: the comment about the test for bug 545855 said
it would generate errors during matching, while when I try
it, the pattern generates a TypeError during compilation. I
don't feel capable to review the code you added to _sre.c;
I'll assign it to Fredrik, but I don't expect him to have
time to look at it. It seems you haven't broken his
requirement for this code to work back to Python 1.5.2. I'll
backport to Python 2.2 as well.

Do I understand correctly that the .*? addition is all Greg
Chapman's work?
msg43342 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2003-04-14 19:50
Logged In: YES 

Gary, I wonder if you could rework your fix for Python 2.2?
The patch doesn't apply cleanly there; one of the problems
is that lastmark_restore() doesn't exist. I wonder if maybe
all of the _sre.c code should simply be copied to the 2.2
msg43343 - (view) Author: Gary Herron (herron) Date: 2003-04-15 16:50
Logged In: YES 

Sure, I'll port it to Python2.2.  I'm surprised it dod not apply 
cleanly there, but then I don't know the history of previous 
patches (like when lastmark_restore was introduced).  I guess 
copying all sre code will be the first thing to try.  How do I get a 
dev version of Python 2.2? 
Yes, the *? code is all Greg Chapman's.  He sent it to me the day 
I announced my volunteering to maintain the sre code.  I wrote 
the test cases for it, and used it as a great way to learn my way 
through the code. 
msg43344 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2003-04-15 18:41
Logged In: YES 

The Python 2.2 maintenance branch is labeled with the CVS
tag 'release22-maint'. I hope you know or can find out about
working with CVS branches. Good luck!
msg43345 - (view) Author: Gary Herron (herron) Date: 2003-04-18 18:57
Logged In: YES 

I copied all the (8) sre files from  the 2.3 branch to the 
release22-maint branch and compiled and ran the test.  It 
worked flawlessly with the single exception that module init 
functions are declared as type 
  DL_EXPORT(void) -- in 2.2 
and as type 
  PyMODINIT_FUNC -- in 2.3 
If there are no considerations other than getting the tests to run 
successfully, then I'll declare success and produce a patch and 
submit it. OK? 
msg43346 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2003-04-18 19:06
Logged In: YES 

Great! Sounds like a plan.
msg43347 - (view) Author: Andrew I MacIntyre (aimacintyre) * (Python triager) Date: 2003-04-20 04:55
Logged In: YES 

This patch has made _sre.c more susceptible to optimisation

The default autoconf optimisation setting for gcc is -O3. 
When _sre.c is so compiled with gcc 2.95.[34] on FreeBSD
4.[47] and gcc 3.2.1 on OS/2+EMX with this level of
optimisation, I get a bus error (sig 10) when running
test_sre (a SYS3171 on OS/2, which is the same thing).

The bus error is not evident with -O2 for gcc 2.95.[34], or
-O for gcc 3.2.1.

Unfortunately I don't have any recent version of gcc
(3.[12].x) available on FreeBSD yet to evaluate.

I have no idea how to introduce a special optimisation
setting just for _sre.c in autoconf, but lowering the
optimisation for all other files seems a major backward step
if its -O3 -> -O; dropping everything from -O3 to -O2 would
be tolerable I think.

As I'm not using autoconf on OS/2, dealing with this is not
a problem there.
msg43348 - (view) Author: Gustavo Niemeyer (niemeyer) * (Python committer) Date: 2003-04-20 07:38
Logged In: YES 

Gary, have you backported the 2.3 _sre.c to 2.2? If so, we
must backport it again, since there are important fixes
relative to 2.2 code, and relative to code introduced in 2.3.
msg43349 - (view) Author: Greg Chapman (glchapman) Date: 2003-04-20 10:47
Logged In: YES 

Andrew, I used some block-scoped locals in the 
MIN_REPEAT_ONE branch (matchmax and c).  I wonder if 
removing those would fix the optimization problem.  I have a 
patch against the latest CVS version (2.91) which I can send 
you if you'd like.  (The patch just moves the test for 65535 
into the while statement and reuses i to hold the result of 
msg43350 - (view) Author: Neal Norwitz (nnorwitz) * (Python committer) Date: 2004-10-21 03:11
Logged In: YES 

Bug 545855 is fixed.  The test cases from this patch seem to
work fine, so I'm closing.
Date User Action Args
2022-04-10 16:08:07adminsetgithub: 38299
2003-04-14 09:14:35herroncreate