classification
Title: test_winreg fails
Type: Stage:
Components: Tests, Windows Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: abbeyj, amaury.forgeotdarc, benjamin.peterson
Priority: normal Keywords:

Created on 2009-06-05 06:45 by abbeyj, last changed 2009-06-09 23:10 by amaury.forgeotdarc. This issue is now closed.

Messages (2)
msg88926 - (view) Author: James Abbatiello (abbeyj) Date: 2009-06-05 06:45
test_winreg fails with:
======================================================================
ERROR: testLocalMachineRegistryWorks (test.test_winreg.WinregTests)
----------------------------------------------------------------------
Traceback (most recent call last):
<snip>
  File "C:\Projects\python-trunk\lib\test\test_winreg.py", line 86, in
ReadTestData
    with OpenKey(key, "sub_key") as sub_key:
AttributeError: __exit__

----------------------------------------------------------------------

_winreg.OpenKey() returns a PyHKEY.  This type can no longer be used in
a "with" statement after r72912 introduced the SETUP_WITH opcode.  The
old way used PyObject_GetAttr() to get __enter__ and __exit__ which
works fine with PyHKEY since it has a tp_getattr function.  The new way
uses _PyObject_LookupSpecial() which uses the MRO and the dict of the
object.

I guess the right fix here is to update PyHKEY so it uses the modern
APIs but I don't know how to do this without breaking the special casing
for the "handle" member.  Using T_INT isn't quite correct since it is a
pointer not an int.
msg89173 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2009-06-09 23:10
Fixed with r73325.
2.7 really introduces an incompatibility here; I added an entry in the 
whatsnew file.
History
Date User Action Args
2009-06-09 23:10:28amaury.forgeotdarcsetstatus: open -> closed

nosy: + amaury.forgeotdarc
messages: + msg89173

resolution: fixed
2009-06-05 08:26:50pitrousetnosy: + benjamin.peterson
2009-06-05 06:45:41abbeyjcreate