Title: 2to3 misses buffer slicing
Type: behavior Stage:
Components: 2to3 (2.x to 3.x conversion tool) Versions: Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: benjamin.peterson Nosy List: benjamin.peterson, joe.amenta
Priority: normal Keywords: patch

Created on 2009-06-03 05:36 by joe.amenta, last changed 2009-06-03 18:10 by benjamin.peterson. This issue is now closed.

File name Uploaded Description Edit
buffertest.patch joe.amenta, 2009-06-03 05:36 This test will fail on the current revision.
bufferfix.patch joe.amenta, 2009-06-03 05:37 This patch will fix the problem and pass the test.
Messages (3)
msg88795 - (view) Author: Joe Amenta (joe.amenta) Date: 2009-06-03 05:36
Found this bug while writing the backwards version of this fix for
3to2... there is no test for it, so it went undetected.  The PATTERN
does not match a buffer() invocation if there is a token after the
rparen, i.e. slicing.
msg88796 - (view) Author: Joe Amenta (joe.amenta) Date: 2009-06-03 05:37
Patch that will fix the problem (and make the test pass)
msg88821 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-06-03 18:10
Thanks for the patch! Fixed in r73179.
Date User Action Args
2009-06-03 18:10:23benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg88821
2009-06-03 11:42:27benjamin.petersonsetpriority: normal
assignee: benjamin.peterson

nosy: + benjamin.peterson
2009-06-03 05:37:11joe.amentasetfiles: + bufferfix.patch

messages: + msg88796
2009-06-03 05:36:24joe.amentacreate