classification
Title: Wrong type check in check_library_list
Type: Stage:
Components: Distutils Versions: Python 3.1
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: tarek Nosy List: cdavid, tarek
Priority: critical Keywords:

Created on 2009-05-05 08:27 by cdavid, last changed 2009-05-06 07:32 by tarek. This issue is now closed.

Messages (3)
msg87224 - (view) Author: Cournapeau David (cdavid) Date: 2009-05-05 08:27
There is a bug in the function check_library_list. Assuming there are
some libraries in the distribution instance, the function checks that
lib[0] is a string, but the test checks exactly the contrary (line 137
of build_clib.py).

This is pretty serious, as any code using libraries will fail to build
on python3. The fix is trivial, though. I think this should be fixed for
python 3.1
msg87235 - (view) Author: Tarek Ziadé (tarek) * (Python committer) Date: 2009-05-05 09:19
Good catch !

Obviously this was introduced when the Python 2 version was
refactored for Python 3

(in python 2 its "if type(lib[0]) is not StringType")

I shall fix this today or tonite (I need to add test coverage
for this command)
msg87312 - (view) Author: Tarek Ziadé (tarek) * (Python committer) Date: 2009-05-06 07:32
fixed in r72379 

Thanks David !

Notice that this bug exists in Python 3.0 too unfortunately.

So I have applied the fix in the 3.0 release branch as well (r72380)
History
Date User Action Args
2009-05-06 07:32:40tareksetstatus: open -> closed

messages: + msg87312
2009-05-05 09:19:30tareksetpriority: critical

messages: + msg87235
2009-05-05 08:27:46cdavidcreate