This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: new "TestCase.skip" method causes all tests to skip under trial (Twisted's test runner)
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.1, Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: benjamin.peterson Nosy List: benjamin.peterson, exarkun, glyph
Priority: release blocker Keywords:

Created on 2009-03-26 19:10 by glyph, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg84198 - (view) Author: Glyph Lefkowitz (glyph) (Python triager) Date: 2009-03-26 19:10
c.f. this Twisted ticket:

Twisted's test tool has an extended TestCase which uses the 'skip'
attribute, on both tests and methods, to determine whether to skip them.
 You can see the implementation here:

The addition of the new 'skip' method in therefore causes
trial, twisted's test tool, to unconditionally skip all tests.

I've set the priority to release blocker because I'd like it to be
determined whether this is really python's fault, or twisted's fault for
subclassing TestCase.

If the new 'skip' method of TestCase is renamed to something else, say
skipTest, this won't be a problem.

While I understand that this is technically a compatible change (the
addition of an attribute) I'd appreciate it if this changed on Python's
side of things, because leaving it up to Twisted means we need to go
through a deprecation cycle on a long-standing, stable public interface
that a lot of test code is using.
msg84210 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2009-03-26 20:06
Renamed to skipTest in r60616.
msg84283 - (view) Author: Jean-Paul Calderone (exarkun) * (Python committer) Date: 2009-03-27 21:47
Hi Benjamin,

Thanks for this fix. :)  I noticed the revision in your comment doesn't
seem to be the one that contains the fix though.
msg84284 - (view) Author: Glyph Lefkowitz (glyph) (Python triager) Date: 2009-03-27 22:14
I went to the trouble of tracking it down and then I forgot to attach a
comment: I'm pretty sure Benjamin meant r70616.
Date User Action Args
2022-04-11 14:56:46adminsetgithub: 49821
2009-03-27 22:14:33glyphsetmessages: + msg84284
2009-03-27 21:47:49exarkunsetnosy: + exarkun
messages: + msg84283
2009-03-26 20:06:18benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg84210
2009-03-26 19:10:15glyphcreate