This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase
Type: Stage: resolved
Components: asyncio, Tests Versions: Python 3.11, Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: asvetlov, kj, miss-islington, yselivanov
Priority: normal Keywords: patch

Created on 2022-03-23 20:42 by asvetlov, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL Status Linked Edit
PR 32086 merged asvetlov, 2022-03-23 20:47
PR 32087 merged miss-islington, 2022-03-23 21:17
PR 32088 closed miss-islington, 2022-03-23 21:17
Messages (4)
msg415913 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2022-03-23 21:17
New changeset ff619c7dfe8dcb0e4c8dc655abc3acc7dc586d0d by Andrew Svetlov in branch 'main':
bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)
https://github.com/python/cpython/commit/ff619c7dfe8dcb0e4c8dc655abc3acc7dc586d0d
msg415914 - (view) Author: miss-islington (miss-islington) Date: 2022-03-23 21:43
New changeset 9e1bfd8ce79b947dc0c1cfb4644e5afe337c2d07 by Miss Islington (bot) in branch '3.10':
bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)
https://github.com/python/cpython/commit/9e1bfd8ce79b947dc0c1cfb4644e5afe337c2d07
msg416890 - (view) Author: Ken Jin (kj) * (Python committer) Date: 2022-04-06 17:35
Andrew, it seems that the post-commit CI has started failing after this commit. Specifically it says "test_asyncio failed (env changed)"

From this page,
https://github.com/python/cpython/commits/3.10?after=3856b4995ec0e632d47b733cdecb5183ac830568+34&branch=3.10

the Ubuntu CI link for that commit:
https://github.com/python/cpython/runs/5667655099?check_suite_focus=true

Failing buildbots on 3.10:
https://buildbot.python.org/all/#/release_status

Sorry that I can't help more. I'm not an asyncio expert so I'm not sure why this is triggering.
msg416893 - (view) Author: Ken Jin (kj) * (Python committer) Date: 2022-04-06 17:56
I forgot to specify, that this is *only* on 3.10, not main.
History
Date User Action Args
2022-04-11 14:59:57adminsetgithub: 91260
2022-04-06 17:56:00kjsetmessages: + msg416893
2022-04-06 17:35:04kjsetstatus: closed -> open

nosy: + kj
messages: + msg416890

resolution: fixed ->
2022-03-23 21:48:20asvetlovsetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: - Python 3.9
2022-03-23 21:43:58miss-islingtonsetmessages: + msg415914
2022-03-23 21:23:34asvetlovsetversions: + Python 3.9
2022-03-23 21:17:24miss-islingtonsetpull_requests: + pull_request30175
2022-03-23 21:17:19miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request30174
2022-03-23 21:17:17asvetlovsetmessages: + msg415913
2022-03-23 20:47:07asvetlovsetkeywords: + patch
stage: patch review
pull_requests: + pull_request30173
2022-03-23 20:42:40asvetlovcreate