This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: CI does not detect launcher installer build failure
Type: Stage: resolved
Components: Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: miss-islington, steve.dower
Priority: normal Keywords: patch

Created on 2022-03-16 00:20 by steve.dower, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31921 merged steve.dower, 2022-03-16 00:38
PR 31926 merged steve.dower, 2022-03-16 01:45
PR 31927 merged steve.dower, 2022-03-16 01:45
Messages (4)
msg415308 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-16 00:20
When changes are made under the Tools/msi directory, extra tests are run in GitHub Actions to build the installer.

Apparently, these tests do not fail when the launcher installer fails to build. They need to.
msg415315 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-16 01:36
New changeset 7c776521418676c074a483266339d31c950f516e by Steve Dower in branch 'main':
bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921)
https://github.com/python/cpython/commit/7c776521418676c074a483266339d31c950f516e
msg415318 - (view) Author: miss-islington (miss-islington) Date: 2022-03-16 02:07
New changeset 04fdbb4f7003a7399f7ba626cf548e2b9dac1045 by Steve Dower in branch '3.10':
[3.10] bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921) (GH-31926)
https://github.com/python/cpython/commit/04fdbb4f7003a7399f7ba626cf548e2b9dac1045
msg415319 - (view) Author: miss-islington (miss-islington) Date: 2022-03-16 02:12
New changeset ad6ddd89006b9fa4836a944c99f8076f26faf299 by Steve Dower in branch '3.9':
[3.9] bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails (GH-31921) (GH-31927)
https://github.com/python/cpython/commit/ad6ddd89006b9fa4836a944c99f8076f26faf299
History
Date User Action Args
2022-04-11 14:59:57adminsetgithub: 91188
2022-03-16 12:23:37steve.dowersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-03-16 02:12:09miss-islingtonsetmessages: + msg415319
2022-03-16 02:07:53miss-islingtonsetnosy: + miss-islington
messages: + msg415318
2022-03-16 01:45:36steve.dowersetpull_requests: + pull_request30018
2022-03-16 01:45:12steve.dowersetpull_requests: + pull_request30017
2022-03-16 01:36:27steve.dowersetmessages: + msg415315
2022-03-16 00:38:22steve.dowersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request30012
2022-03-16 00:20:54steve.dowercreate